Message ID | alpine.DEB.2.20.2311171447330.5892@tpp.orcam.me.uk |
---|---|
State | New |
Headers | show
Return-Path: <gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=embecosm.com header.i=@embecosm.com header.a=rsa-sha256 header.s=google header.b=Z0lNExAS; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=8.43.85.97; helo=server2.sourceware.org; envelope-from=gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=patchwork.ozlabs.org) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4SXzsm6CLBz1ySJ for <incoming@patchwork.ozlabs.org>; Sun, 19 Nov 2023 16:37:00 +1100 (AEDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 98DF73858287 for <incoming@patchwork.ozlabs.org>; Sun, 19 Nov 2023 05:36:57 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mail-ed1-x533.google.com (mail-ed1-x533.google.com [IPv6:2a00:1450:4864:20::533]) by sourceware.org (Postfix) with ESMTPS id 3AA043857C7C for <gcc-patches@gcc.gnu.org>; Sun, 19 Nov 2023 05:36:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3AA043857C7C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=embecosm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=embecosm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 3AA043857C7C Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::533 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700372196; cv=none; b=D1s0DSEX1SN6+2D/eay1BfPqQgCFgBD95+ibVDjvIv9YGY1BnqcEt0ASaaI8wj5+Ylk0Qmzr77I1D6Wj7VSPokZGTp+EN0dy5J+G+haEBgMoxpi9WTJxsDC8JOg7qZYau2waat6O9AWwhIKa7Ctcba+zzG3LTbdhppa/aqbZrJw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700372196; c=relaxed/simple; bh=b2AQK7sZlrKjVJ8yvPhYLcBVoOxlVGXi18kLfcScaOs=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=vxZI/TRcWF26onqTmwzNDBtjQqPxlWsT2X0lZjDQBzhbwJyhS9zpdIVt7KrV+gJEn4NBfGAFLf2JB58gw7axwCFfLgtXLSOIYyoO56nvZf2g18DVGf6lW0tf4509bMrn9RD4saRvqv6K/3lQlSmsd/ZBFVvnakv5GUzOvW5TU0w= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-ed1-x533.google.com with SMTP id 4fb4d7f45d1cf-5446c9f3a77so4893712a12.0 for <gcc-patches@gcc.gnu.org>; Sat, 18 Nov 2023 21:36:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; t=1700372194; x=1700976994; darn=gcc.gnu.org; h=mime-version:user-agent:references:message-id:in-reply-to:subject :cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=BAObHUL+u7i7Tm1MzRpZlhj4SxaR1+F0BolaNOMaSlo=; b=Z0lNExASJH1IGmtKMVDnNyPUDQGww29OLaKO0vTQ0fibTAmi+nfB3IqomFw7H8racu ERczW23m9cY7L2BP3Sm6CVaS9ssy0zVLYxn4nCuuSzNM0sf+O22geX4wpJbQ3evVCemR Wn145xyVRAE6l+xYbtwEBYMs6iBON2iSMaaooy961149SM3spMhNul53ckuy7/1ZMbQp jdm2Rkc6Ko5VjnjHXJBFFVtBdbgroFMZyTHjBGQB/BfnH1GjFaebdUShOnMYt3M+MNn/ 02pnydT6/l4jefezReYuyw+ffesIq0oAaxCKVT87CFNA5mxfL4ME6ytLmae/s5dHFk0b puIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700372194; x=1700976994; h=mime-version:user-agent:references:message-id:in-reply-to:subject :cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=BAObHUL+u7i7Tm1MzRpZlhj4SxaR1+F0BolaNOMaSlo=; b=Sitm92vQwiyxXTHhJUsH9zlBDC33oFQkAePEedz7umXphJVrmBJCYVzANllcWiAMAx OM0lSQJa5gdqFAAoMM2ZiG47j1twGEqhY4OBZt3/mtYV2JstXY3V2yJfnYckPRd9U4HR /3p/oRhDduqNw1/9mxje69kLjfNgKVxew7XzmkbB0ASLu+ISGIQZjOwBAmikoRXDPCJR 9yCa547Ew75lRbmAvmUGj5at86BGzd82vAQjdpCjW93zL9t3FAxfX4BOOKhQiqvMiiO+ chm8FEQg7Hi0HUEkCNTNLO3bAO28GbcM2dxbAtVR/2SIH5NMZmuJMNVF/etO0+RF0WCC 3sCA== X-Gm-Message-State: AOJu0Yz1xjsdrHsPH1OTrBYahic4L99sMOfJb3HMWIEum+QvOwpbdjyw 7swl1nP8eqIC1id7gYue4v3mVYYwpYQRlJWFGJd7pg== X-Google-Smtp-Source: AGHT+IGN5jDq9wbzp8kiIkPQWXrmqjxTNdd2ZugdpCcNT5GpgmdzBpHLMlm2pvzbZPA6qXp2lcUl1A== X-Received: by 2002:a17:907:788f:b0:9ae:5253:175b with SMTP id ku15-20020a170907788f00b009ae5253175bmr3520588ejc.34.1700372193993; Sat, 18 Nov 2023 21:36:33 -0800 (PST) Received: from [192.168.219.3] ([78.8.192.131]) by smtp.gmail.com with ESMTPSA id l5-20020a170906a40500b009cd52d08563sm2521753ejz.223.2023.11.18.21.36.32 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 18 Nov 2023 21:36:33 -0800 (PST) Date: Sun, 19 Nov 2023 05:36:31 +0000 (GMT) From: "Maciej W. Rozycki" <macro@embecosm.com> To: gcc-patches@gcc.gnu.org cc: Andrew Waterman <andrew@sifive.com>, Jim Wilson <jim.wilson.gcc@gmail.com>, Kito Cheng <kito.cheng@gmail.com>, Palmer Dabbelt <palmer@dabbelt.com> Subject: [PATCH 07/44] RISC-V: Use `nullptr' in `riscv_expand_conditional_move' In-Reply-To: <alpine.DEB.2.20.2311171315580.5892@tpp.orcam.me.uk> Message-ID: <alpine.DEB.2.20.2311171447330.5892@tpp.orcam.me.uk> References: <alpine.DEB.2.20.2311171315580.5892@tpp.orcam.me.uk> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE, URIBL_BLACK autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org> List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-patches>, <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe> List-Archive: <https://gcc.gnu.org/pipermail/gcc-patches/> List-Post: <mailto:gcc-patches@gcc.gnu.org> List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help> List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-patches>, <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe> Errors-To: gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org |
Series |
RISC-V: Various if-conversion fixes and improvements
|
expand
|
LGTM On Sun, Nov 19, 2023 at 1:37 PM Maciej W. Rozycki <macro@embecosm.com> wrote: > > Use `nullptr' for consistency rather than 0 to initialize `invert_ptr'. > > gcc/ > * config/riscv/riscv.cc (riscv_expand_conditional_move): Use > `nullptr' rather than 0 to initialize a pointer. > --- > gcc/config/riscv/riscv.cc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > gcc-riscv-expand-conditional-move-nullptr.diff > Index: gcc/gcc/config/riscv/riscv.cc > =================================================================== > --- gcc.orig/gcc/config/riscv/riscv.cc > +++ gcc/gcc/config/riscv/riscv.cc > @@ -4024,7 +4024,7 @@ riscv_expand_conditional_move (rtx dest, > if (!equality_operator (op, VOIDmode) || op1 != CONST0_RTX (mode)) > { > enum rtx_code new_code = NE; > - bool *invert_ptr = 0; > + bool *invert_ptr = nullptr; > bool invert = false; > > if (code == LE || code == GE)
Index: gcc/gcc/config/riscv/riscv.cc =================================================================== --- gcc.orig/gcc/config/riscv/riscv.cc +++ gcc/gcc/config/riscv/riscv.cc @@ -4024,7 +4024,7 @@ riscv_expand_conditional_move (rtx dest, if (!equality_operator (op, VOIDmode) || op1 != CONST0_RTX (mode)) { enum rtx_code new_code = NE; - bool *invert_ptr = 0; + bool *invert_ptr = nullptr; bool invert = false; if (code == LE || code == GE)