diff mbox series

[03/44] RISC-V: Reorder comment on SFB patterns

Message ID alpine.DEB.2.20.2311171356430.5892@tpp.orcam.me.uk
State New
Headers show
Series RISC-V: Various if-conversion fixes and improvements | expand

Commit Message

Maciej W. Rozycki Nov. 19, 2023, 5:35 a.m. UTC 
Our `mov<mode>cc' expander is no longer specific to short forward branch 
targets, so move its associated comment accordingly.

	gcc/
	* config/riscv/riscv.md (mov<mode>cc): Move comment on SFB 
	patterns over to...
	(*mov<GPR:mode><X:mode>cc): ... here.
---
 gcc/config/riscv/riscv.md |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

gcc-riscv-sfb-comment-move.diff

Comments

Kito Cheng Nov. 19, 2023, 5:53 a.m. UTC | #1 
LGTM

On Sun, Nov 19, 2023 at 1:36 PM Maciej W. Rozycki <macro@embecosm.com> wrote:
>
> Our `mov<mode>cc' expander is no longer specific to short forward branch
> targets, so move its associated comment accordingly.
>
>         gcc/
>         * config/riscv/riscv.md (mov<mode>cc): Move comment on SFB
>         patterns over to...
>         (*mov<GPR:mode><X:mode>cc): ... here.
> ---
>  gcc/config/riscv/riscv.md |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> gcc-riscv-sfb-comment-move.diff
> Index: gcc-master/gcc/config/riscv/riscv.md
> ===================================================================
> --- gcc-master.orig/gcc/config/riscv/riscv.md
> +++ gcc-master/gcc/config/riscv/riscv.md
> @@ -2655,8 +2655,6 @@
>    [(set_attr "type" "branch")
>     (set_attr "mode" "none")])
>
> -;; Patterns for implementations that optimize short forward branches.
> -
>  (define_expand "mov<mode>cc"
>    [(set (match_operand:GPR 0 "register_operand")
>         (if_then_else:GPR (match_operand 1 "comparison_operator")
> @@ -2671,6 +2669,8 @@
>      FAIL;
>  })
>
> +;; Patterns for implementations that optimize short forward branches.
> +
>  (define_insn "*mov<GPR:mode><X:mode>cc"
>    [(set (match_operand:GPR 0 "register_operand" "=r,r")
>         (if_then_else:GPR
diff mbox series

Patch

Index: gcc-master/gcc/config/riscv/riscv.md
===================================================================
--- gcc-master.orig/gcc/config/riscv/riscv.md
+++ gcc-master/gcc/config/riscv/riscv.md
@@ -2655,8 +2655,6 @@ 
   [(set_attr "type" "branch")
    (set_attr "mode" "none")])
 
-;; Patterns for implementations that optimize short forward branches.
-
 (define_expand "mov<mode>cc"
   [(set (match_operand:GPR 0 "register_operand")
 	(if_then_else:GPR (match_operand 1 "comparison_operator")
@@ -2671,6 +2669,8 @@ 
     FAIL;
 })
 
+;; Patterns for implementations that optimize short forward branches.
+
 (define_insn "*mov<GPR:mode><X:mode>cc"
   [(set (match_operand:GPR 0 "register_operand" "=r,r")
 	(if_then_else:GPR