On Wed, Sep 25, 2019 at 10:59 PM Simon Glass <sjg@chromium.org> wrote: > > At present the interrupt table is included in all phases of U-Boot. Allow > it to be omitted, e.g. in TPL, to reduce size. > > Signed-off-by: Simon Glass <sjg@chromium.org> > --- > > arch/x86/cpu/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
On Thu, Oct 10, 2019 at 5:26 PM Bin Meng <bmeng.cn@gmail.com> wrote: > > On Wed, Sep 25, 2019 at 10:59 PM Simon Glass <sjg@chromium.org> wrote: > > > > At present the interrupt table is included in all phases of U-Boot. Allow > > it to be omitted, e.g. in TPL, to reduce size. > > > > Signed-off-by: Simon Glass <sjg@chromium.org> > > --- > > > > arch/x86/cpu/Makefile | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > Reviewed-by: Bin Meng <bmeng.cn@gmail.com> applied to u-boot-x86, thanks!
Hi Simon, On Fri, Oct 11, 2019 at 4:35 PM Bin Meng <bmeng.cn@gmail.com> wrote: > > On Thu, Oct 10, 2019 at 5:26 PM Bin Meng <bmeng.cn@gmail.com> wrote: > > > > On Wed, Sep 25, 2019 at 10:59 PM Simon Glass <sjg@chromium.org> wrote: > > > > > > At present the interrupt table is included in all phases of U-Boot. Allow > > > it to be omitted, e.g. in TPL, to reduce size. > > > > > > Signed-off-by: Simon Glass <sjg@chromium.org> > > > --- > > > > > > arch/x86/cpu/Makefile | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > Reviewed-by: Bin Meng <bmeng.cn@gmail.com> > > applied to u-boot-x86, thanks! This unfortunately breaks qemu-x86_64_defconfig. 06: x86: Allow interrupt to happen once x86: + qemu-x86_64 +arch/x86/lib/built-in.o:build/../arch/x86/lib/tables.c:22: undefined reference to `write_pirq_routing_table' +make[1]: *** [u-boot] Error 1 +make: *** [sub-make] Error 2 I will have to drop this patch from my queue. Regards, Bin
diff --git a/arch/x86/cpu/Makefile b/arch/x86/cpu/Makefile index 6296b55ff8a..b6a010ea320 100644 --- a/arch/x86/cpu/Makefile +++ b/arch/x86/cpu/Makefile @@ -53,7 +53,7 @@ obj-$(CONFIG_INTEL_QUARK) += quark/ obj-$(CONFIG_INTEL_QUEENSBAY) += queensbay/ obj-$(CONFIG_INTEL_TANGIER) += tangier/ obj-$(CONFIG_APIC) += lapic.o ioapic.o -obj-y += irq.o +obj-$(CONFIG_$(SPL_TPL_)X86_32BIT_INIT) += irq.o ifndef CONFIG_$(SPL_)X86_64 obj-$(CONFIG_SMP) += mp_init.o endif
At present the interrupt table is included in all phases of U-Boot. Allow it to be omitted, e.g. in TPL, to reduce size. Signed-off-by: Simon Glass <sjg@chromium.org> --- arch/x86/cpu/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)