diff mbox series

[U-Boot,034/126] serial: ns16550: Add a PCI device/function field

Message ID 20190925145750.200592-35-sjg@chromium.org
State Accepted
Commit 4e8de068a3b210c0fea2b29372b25c60c7b6dc9e
Delegated to: Bin Meng
Headers show
Series x86: Add initial support for apollolake | expand

Commit Message

Simon Glass Sept. 25, 2019, 2:56 p.m. UTC
When this UART is used early in boot (before PCI is set up) it is
convenient to store the PCI BDF of the UART so that it can be manually
configured. This is useful when it is used as a debug UART, for example.

Add a new field to hold this information, so that drivers can simply use
the existing platform data.

Signed-off-by: Simon Glass <sjg@chromium.org>
---

 include/ns16550.h | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Bin Meng Oct. 5, 2019, 1:12 p.m. UTC | #1
On Wed, Sep 25, 2019 at 10:58 PM Simon Glass <sjg@chromium.org> wrote:
>
> When this UART is used early in boot (before PCI is set up) it is
> convenient to store the PCI BDF of the UART so that it can be manually
> configured. This is useful when it is used as a debug UART, for example.
>
> Add a new field to hold this information, so that drivers can simply use
> the existing platform data.
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
> ---
>
>  include/ns16550.h | 4 ++++
>  1 file changed, 4 insertions(+)
>

Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
Bin Meng Oct. 6, 2019, 11:19 a.m. UTC | #2
On Sat, Oct 5, 2019 at 9:12 PM Bin Meng <bmeng.cn@gmail.com> wrote:
>
> On Wed, Sep 25, 2019 at 10:58 PM Simon Glass <sjg@chromium.org> wrote:
> >
> > When this UART is used early in boot (before PCI is set up) it is
> > convenient to store the PCI BDF of the UART so that it can be manually
> > configured. This is useful when it is used as a debug UART, for example.
> >
> > Add a new field to hold this information, so that drivers can simply use
> > the existing platform data.
> >
> > Signed-off-by: Simon Glass <sjg@chromium.org>
> > ---
> >
> >  include/ns16550.h | 4 ++++
> >  1 file changed, 4 insertions(+)
> >
>
> Reviewed-by: Bin Meng <bmeng.cn@gmail.com>

applied to u-boot-x86/next, thanks!
diff mbox series

Patch

diff --git a/include/ns16550.h b/include/ns16550.h
index 22b89e4d6d1..701efeea855 100644
--- a/include/ns16550.h
+++ b/include/ns16550.h
@@ -52,6 +52,7 @@ 
  * @reg_width:		IO accesses size of registers (in bytes)
  * @reg_shift:		Shift size of registers (0=byte, 1=16bit, 2=32bit...)
  * @clock:		UART base clock speed in Hz
+ * @bdf:		PCI slot/function (pci_dev_t)
  */
 struct ns16550_platdata {
 	unsigned long base;
@@ -60,6 +61,9 @@  struct ns16550_platdata {
 	int reg_offset;
 	int clock;
 	u32 fcr;
+#if defined(CONFIG_PCI) && defined(CONFIG_SPL)
+	int bdf;
+#endif
 };
 
 struct udevice;