diff mbox series

[U-Boot,013/126] dm: test: Correct a stray backslash in dm_test_destroy()

Message ID 20190925145750.200592-14-sjg@chromium.org
State Accepted
Delegated to: Bin Meng
Headers show
Series x86: Add initial support for apollolake | expand

Commit Message

Simon Glass Sept. 25, 2019, 2:55 p.m. UTC 
This should perhaps be a period but it is not necessary. Remove it.

Signed-off-by: Simon Glass <sjg@chromium.org>
---

 test/dm/test-main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Bin Meng Oct. 4, 2019, 9:44 a.m. UTC | #1 
On Wed, Sep 25, 2019 at 10:58 PM Simon Glass <sjg@chromium.org> wrote:
>
> This should perhaps be a period but it is not necessary. Remove it.
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
> ---
>
>  test/dm/test-main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/test/dm/test-main.c b/test/dm/test-main.c
> index 74f77ccc849..c944ab9c5f2 100644
> --- a/test/dm/test-main.c
> +++ b/test/dm/test-main.c
> @@ -64,7 +64,7 @@ static int dm_test_destroy(struct unit_test_state *uts)
>
>                 /*
>                  * If the uclass doesn't exist we don't want to create it. So
> -                * check that here before we call uclass_find_device()/
> +                * check that here before we call uclass_find_device()

I tend to use a period since it's a complete sentence.

>                  */
>                 uc = uclass_find(id);
>                 if (!uc)
> --

Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
Bin Meng Oct. 6, 2019, 9:27 a.m. UTC | #2 
On Fri, Oct 4, 2019 at 5:44 PM Bin Meng <bmeng.cn@gmail.com> wrote:
>
> On Wed, Sep 25, 2019 at 10:58 PM Simon Glass <sjg@chromium.org> wrote:
> >
> > This should perhaps be a period but it is not necessary. Remove it.
> >
> > Signed-off-by: Simon Glass <sjg@chromium.org>
> > ---
> >
> >  test/dm/test-main.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/test/dm/test-main.c b/test/dm/test-main.c
> > index 74f77ccc849..c944ab9c5f2 100644
> > --- a/test/dm/test-main.c
> > +++ b/test/dm/test-main.c
> > @@ -64,7 +64,7 @@ static int dm_test_destroy(struct unit_test_state *uts)
> >
> >                 /*
> >                  * If the uclass doesn't exist we don't want to create it. So
> > -                * check that here before we call uclass_find_device()/
> > +                * check that here before we call uclass_find_device()
>
> I tend to use a period since it's a complete sentence.

Added the ending period, reworded the commit message, and

>
> >                  */
> >                 uc = uclass_find(id);
> >                 if (!uc)
> > --
>
> Reviewed-by: Bin Meng <bmeng.cn@gmail.com>

applied to u-boot-x86/next, thanks!
diff mbox series

Patch

diff --git a/test/dm/test-main.c b/test/dm/test-main.c
index 74f77ccc849..c944ab9c5f2 100644
--- a/test/dm/test-main.c
+++ b/test/dm/test-main.c
@@ -64,7 +64,7 @@  static int dm_test_destroy(struct unit_test_state *uts)
 
 		/*
 		 * If the uclass doesn't exist we don't want to create it. So
-		 * check that here before we call uclass_find_device()/
+		 * check that here before we call uclass_find_device()
 		 */
 		uc = uclass_find(id);
 		if (!uc)