| Message ID | 20240409150215.2497778-9-patrice.chotard@foss.st.com |
|---|---|
| State | Accepted |
| Commit | 1e26c20662e9a7483e64d609aab286235fe13a3b |
| Delegated to: | Patrick Delaunay |
| Headers | show |
| Series | stm32mp: Fix keys & leds management | expand |
Hi, On 4/9/24 17:01, Patrice Chotard wrote: > led-red and button dedicated to fastboot share the same gpio GPIOA13. > led-blue and button dedicated to stm32prog share the same gpio GPIOA14. > Led driver is probed early so the corresponding gpio is taken and > configured in output which forbid fastboot and stm32prog button usage. > > To avoid this, remove the "default-state" property from led-red and > led-blue led's node. > > This will avoid to trigger the led driver probe() to configure the led > default state during startup. > > Signed-off-by: Patrice Chotard <patrice.chotard@foss.st.com> > --- > > arch/arm/dts/stm32mp135f-dk-u-boot.dtsi | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > Reviewed-by: Patrick Delaunay <patrick.delaunay@foss.st.com> Thanks Patrick
On 4/17/24 11:06, Patrick DELAUNAY wrote: > Hi, > > On 4/9/24 17:01, Patrice Chotard wrote: >> led-red and button dedicated to fastboot share the same gpio GPIOA13. >> led-blue and button dedicated to stm32prog share the same gpio GPIOA14. >> Led driver is probed early so the corresponding gpio is taken and >> configured in output which forbid fastboot and stm32prog button usage. >> >> To avoid this, remove the "default-state" property from led-red and >> led-blue led's node. >> >> This will avoid to trigger the led driver probe() to configure the led >> default state during startup. >> >> Signed-off-by: Patrice Chotard <patrice.chotard@foss.st.com> >> --- >> >> arch/arm/dts/stm32mp135f-dk-u-boot.dtsi | 5 ++++- >> 1 file changed, 4 insertions(+), 1 deletion(-) >> > > > Reviewed-by: Patrick Delaunay <patrick.delaunay@foss.st.com> > > Thanks > Patrick > Applied on u-boot-stm32/master
diff --git a/arch/arm/dts/stm32mp135f-dk-u-boot.dtsi b/arch/arm/dts/stm32mp135f-dk-u-boot.dtsi index e64ded13462..8f42735609a 100644 --- a/arch/arm/dts/stm32mp135f-dk-u-boot.dtsi +++ b/arch/arm/dts/stm32mp135f-dk-u-boot.dtsi @@ -30,10 +30,13 @@ }; leds { + led-blue { + /delete-property/default-state; + }; + led-red { color = <LED_COLOR_ID_RED>; gpios = <&gpioa 13 GPIO_ACTIVE_LOW>; - default-state = "off"; }; }; };
led-red and button dedicated to fastboot share the same gpio GPIOA13. led-blue and button dedicated to stm32prog share the same gpio GPIOA14. Led driver is probed early so the corresponding gpio is taken and configured in output which forbid fastboot and stm32prog button usage. To avoid this, remove the "default-state" property from led-red and led-blue led's node. This will avoid to trigger the led driver probe() to configure the led default state during startup. Signed-off-by: Patrice Chotard <patrice.chotard@foss.st.com> --- arch/arm/dts/stm32mp135f-dk-u-boot.dtsi | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)