| Message ID | 20240409150215.2497778-14-patrice.chotard@foss.st.com |
|---|---|
| State | Accepted |
| Commit | 13a504ef32da389944858c195f1f7846a5f23169 |
| Delegated to: | Patrick Delaunay |
| Headers | show |
| Series | stm32mp: Fix keys & leds management | expand |
Hi, On 4/9/24 17:02, Patrice Chotard wrote: > As indicated in kernel led dt-bindings, label is a deprecated > property, so remove it and use blue led node's name instead > for u-boot,boot-led property. > > Signed-off-by: Patrice Chotard <patrice.chotard@foss.st.com> > --- > > arch/arm/dts/stm32mp157a-dk1-scmi-u-boot.dtsi | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/arch/arm/dts/stm32mp157a-dk1-scmi-u-boot.dtsi b/arch/arm/dts/stm32mp157a-dk1-scmi-u-boot.dtsi > index e61814fd66e..a5158fec7ef 100644 > --- a/arch/arm/dts/stm32mp157a-dk1-scmi-u-boot.dtsi > +++ b/arch/arm/dts/stm32mp157a-dk1-scmi-u-boot.dtsi > @@ -13,7 +13,7 @@ > }; > > config { > - u-boot,boot-led = "heartbeat"; > + u-boot,boot-led = "led-blue"; > u-boot,error-led = "led-red"; > u-boot,mmc-env-partition = "u-boot-env"; > st,adc_usb_pd = <&adc1 18>, <&adc1 19>; > @@ -36,6 +36,10 @@ > }; > > led { > + led-blue { > + /delete-property/label; > + }; > + > led-red { > gpios = <&gpioa 13 GPIO_ACTIVE_LOW>; > }; Reviewed-by: Patrick Delaunay <patrick.delaunay@foss.st.com> Thanks Patrick
On 4/17/24 11:09, Patrick DELAUNAY wrote: > Hi, > > On 4/9/24 17:02, Patrice Chotard wrote: >> As indicated in kernel led dt-bindings, label is a deprecated >> property, so remove it and use blue led node's name instead >> for u-boot,boot-led property. >> >> Signed-off-by: Patrice Chotard <patrice.chotard@foss.st.com> >> --- >> >> arch/arm/dts/stm32mp157a-dk1-scmi-u-boot.dtsi | 6 +++++- >> 1 file changed, 5 insertions(+), 1 deletion(-) >> >> diff --git a/arch/arm/dts/stm32mp157a-dk1-scmi-u-boot.dtsi b/arch/arm/dts/stm32mp157a-dk1-scmi-u-boot.dtsi >> index e61814fd66e..a5158fec7ef 100644 >> --- a/arch/arm/dts/stm32mp157a-dk1-scmi-u-boot.dtsi >> +++ b/arch/arm/dts/stm32mp157a-dk1-scmi-u-boot.dtsi >> @@ -13,7 +13,7 @@ >> }; >> config { >> - u-boot,boot-led = "heartbeat"; >> + u-boot,boot-led = "led-blue"; >> u-boot,error-led = "led-red"; >> u-boot,mmc-env-partition = "u-boot-env"; >> st,adc_usb_pd = <&adc1 18>, <&adc1 19>; >> @@ -36,6 +36,10 @@ >> }; >> led { >> + led-blue { >> + /delete-property/label; >> + }; >> + >> led-red { >> gpios = <&gpioa 13 GPIO_ACTIVE_LOW>; >> }; > > > > Reviewed-by: Patrick Delaunay <patrick.delaunay@foss.st.com> > > Thanks > Patrick > Applied on u-boot-stm32/master
diff --git a/arch/arm/dts/stm32mp157a-dk1-scmi-u-boot.dtsi b/arch/arm/dts/stm32mp157a-dk1-scmi-u-boot.dtsi index e61814fd66e..a5158fec7ef 100644 --- a/arch/arm/dts/stm32mp157a-dk1-scmi-u-boot.dtsi +++ b/arch/arm/dts/stm32mp157a-dk1-scmi-u-boot.dtsi @@ -13,7 +13,7 @@ }; config { - u-boot,boot-led = "heartbeat"; + u-boot,boot-led = "led-blue"; u-boot,error-led = "led-red"; u-boot,mmc-env-partition = "u-boot-env"; st,adc_usb_pd = <&adc1 18>, <&adc1 19>; @@ -36,6 +36,10 @@ }; led { + led-blue { + /delete-property/label; + }; + led-red { gpios = <&gpioa 13 GPIO_ACTIVE_LOW>; };
As indicated in kernel led dt-bindings, label is a deprecated property, so remove it and use blue led node's name instead for u-boot,boot-led property. Signed-off-by: Patrice Chotard <patrice.chotard@foss.st.com> --- arch/arm/dts/stm32mp157a-dk1-scmi-u-boot.dtsi | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)