| Message ID | 20240409150215.2497778-13-patrice.chotard@foss.st.com |
|---|---|
| State | Accepted |
| Commit | 1ca33cbfd96f394ebbeab73d6771bf34c7b2f502 |
| Delegated to: | Patrick Delaunay |
| Headers | show |
| Series | stm32mp: Fix keys & leds management | expand |
Hi, On 4/9/24 17:02, Patrice Chotard wrote: > As indicated in kernel led dt-bindings, label is a deprecated > property, so remove it and use red led node's name instead > for u-boot,error-led property. > Rename "red" led node's name to "led-red". > Remove status property which is useless. > > Signed-off-by: Patrice Chotard <patrice.chotard@foss.st.com> > --- > > arch/arm/dts/stm32mp157a-dk1-scmi-u-boot.dtsi | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/arch/arm/dts/stm32mp157a-dk1-scmi-u-boot.dtsi b/arch/arm/dts/stm32mp157a-dk1-scmi-u-boot.dtsi > index 8760d6c7d93..e61814fd66e 100644 > --- a/arch/arm/dts/stm32mp157a-dk1-scmi-u-boot.dtsi > +++ b/arch/arm/dts/stm32mp157a-dk1-scmi-u-boot.dtsi > @@ -14,7 +14,7 @@ > > config { > u-boot,boot-led = "heartbeat"; > - u-boot,error-led = "error"; > + u-boot,error-led = "led-red"; > u-boot,mmc-env-partition = "u-boot-env"; > st,adc_usb_pd = <&adc1 18>, <&adc1 19>; > }; > @@ -36,10 +36,8 @@ > }; > > led { > - red { > - label = "error"; > + led-red { > gpios = <&gpioa 13 GPIO_ACTIVE_LOW>; > - status = "okay"; > }; > }; > }; Reviewed-by: Patrick Delaunay <patrick.delaunay@foss.st.com> Thanks Patrick
On 4/17/24 11:08, Patrick DELAUNAY wrote: > Hi, > > On 4/9/24 17:02, Patrice Chotard wrote: >> As indicated in kernel led dt-bindings, label is a deprecated >> property, so remove it and use red led node's name instead >> for u-boot,error-led property. >> Rename "red" led node's name to "led-red". >> Remove status property which is useless. >> >> Signed-off-by: Patrice Chotard <patrice.chotard@foss.st.com> >> --- >> >> arch/arm/dts/stm32mp157a-dk1-scmi-u-boot.dtsi | 6 ++---- >> 1 file changed, 2 insertions(+), 4 deletions(-) >> >> diff --git a/arch/arm/dts/stm32mp157a-dk1-scmi-u-boot.dtsi b/arch/arm/dts/stm32mp157a-dk1-scmi-u-boot.dtsi >> index 8760d6c7d93..e61814fd66e 100644 >> --- a/arch/arm/dts/stm32mp157a-dk1-scmi-u-boot.dtsi >> +++ b/arch/arm/dts/stm32mp157a-dk1-scmi-u-boot.dtsi >> @@ -14,7 +14,7 @@ >> config { >> u-boot,boot-led = "heartbeat"; >> - u-boot,error-led = "error"; >> + u-boot,error-led = "led-red"; >> u-boot,mmc-env-partition = "u-boot-env"; >> st,adc_usb_pd = <&adc1 18>, <&adc1 19>; >> }; >> @@ -36,10 +36,8 @@ >> }; >> led { >> - red { >> - label = "error"; >> + led-red { >> gpios = <&gpioa 13 GPIO_ACTIVE_LOW>; >> - status = "okay"; >> }; >> }; >> }; > > > > Reviewed-by: Patrick Delaunay <patrick.delaunay@foss.st.com> > > Thanks > Patrick > Applied on u-boot-stm32/master
diff --git a/arch/arm/dts/stm32mp157a-dk1-scmi-u-boot.dtsi b/arch/arm/dts/stm32mp157a-dk1-scmi-u-boot.dtsi index 8760d6c7d93..e61814fd66e 100644 --- a/arch/arm/dts/stm32mp157a-dk1-scmi-u-boot.dtsi +++ b/arch/arm/dts/stm32mp157a-dk1-scmi-u-boot.dtsi @@ -14,7 +14,7 @@ config { u-boot,boot-led = "heartbeat"; - u-boot,error-led = "error"; + u-boot,error-led = "led-red"; u-boot,mmc-env-partition = "u-boot-env"; st,adc_usb_pd = <&adc1 18>, <&adc1 19>; }; @@ -36,10 +36,8 @@ }; led { - red { - label = "error"; + led-red { gpios = <&gpioa 13 GPIO_ACTIVE_LOW>; - status = "okay"; }; }; };
As indicated in kernel led dt-bindings, label is a deprecated property, so remove it and use red led node's name instead for u-boot,error-led property. Rename "red" led node's name to "led-red". Remove status property which is useless. Signed-off-by: Patrice Chotard <patrice.chotard@foss.st.com> --- arch/arm/dts/stm32mp157a-dk1-scmi-u-boot.dtsi | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)