| Message ID | 20240409150215.2497778-24-patrice.chotard@foss.st.com |
|---|---|
| State | Accepted |
| Commit | e43a0d05bfbe0163ceb1c199fccbaed0f2186a21 |
| Delegated to: | Patrick Delaunay |
| Headers | show |
| Series | stm32mp: Fix keys & leds management | expand |
Hi, On 4/9/24 17:02, Patrice Chotard wrote: > red led and button dedicated to fastboot share the same gpio GPIOA13. > Led driver is probed early so the corresponding gpio is taken and > configured in output which forbid fastboot and stm32prog button usage. > > To avoid this, remove the "default-state" property from red led node. > > This will avoid to trigger the led driver probe() to configure the led > default state during startup. > > Signed-off-by: Patrice Chotard <patrice.chotard@foss.st.com> > --- > > arch/arm/dts/stm32mp157c-ed1-scmi-u-boot.dtsi | 1 - > 1 file changed, 1 deletion(-) > Reviewed-by: Patrick Delaunay <patrick.delaunay@foss.st.com> Thanks Patrick
On 4/9/24 17:02, Patrice Chotard wrote: > red led and button dedicated to fastboot share the same gpio GPIOA13. > Led driver is probed early so the corresponding gpio is taken and > configured in output which forbid fastboot and stm32prog button usage. > > To avoid this, remove the "default-state" property from red led node. > > This will avoid to trigger the led driver probe() to configure the led > default state during startup. > > Signed-off-by: Patrice Chotard <patrice.chotard@foss.st.com> > --- > > arch/arm/dts/stm32mp157c-ed1-scmi-u-boot.dtsi | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/arch/arm/dts/stm32mp157c-ed1-scmi-u-boot.dtsi b/arch/arm/dts/stm32mp157c-ed1-scmi-u-boot.dtsi > index 84920f53496..2abd512e297 100644 > --- a/arch/arm/dts/stm32mp157c-ed1-scmi-u-boot.dtsi > +++ b/arch/arm/dts/stm32mp157c-ed1-scmi-u-boot.dtsi > @@ -37,7 +37,6 @@ > red { > label = "error"; > gpios = <&gpioa 13 GPIO_ACTIVE_LOW>; > - default-state = "off"; > status = "okay"; > }; > }; Applied on u-boot-stm32/master
On 4/17/24 11:13, Patrick DELAUNAY wrote: > Hi, > > On 4/9/24 17:02, Patrice Chotard wrote: >> red led and button dedicated to fastboot share the same gpio GPIOA13. >> Led driver is probed early so the corresponding gpio is taken and >> configured in output which forbid fastboot and stm32prog button usage. >> >> To avoid this, remove the "default-state" property from red led node. >> >> This will avoid to trigger the led driver probe() to configure the led >> default state during startup. >> >> Signed-off-by: Patrice Chotard <patrice.chotard@foss.st.com> >> --- >> >> arch/arm/dts/stm32mp157c-ed1-scmi-u-boot.dtsi | 1 - >> 1 file changed, 1 deletion(-) >> > > > Reviewed-by: Patrick Delaunay <patrick.delaunay@foss.st.com> > > Thanks > Patrick > Applied on u-boot-stm32/master
diff --git a/arch/arm/dts/stm32mp157c-ed1-scmi-u-boot.dtsi b/arch/arm/dts/stm32mp157c-ed1-scmi-u-boot.dtsi index 84920f53496..2abd512e297 100644 --- a/arch/arm/dts/stm32mp157c-ed1-scmi-u-boot.dtsi +++ b/arch/arm/dts/stm32mp157c-ed1-scmi-u-boot.dtsi @@ -37,7 +37,6 @@ red { label = "error"; gpios = <&gpioa 13 GPIO_ACTIVE_LOW>; - default-state = "off"; status = "okay"; }; };
red led and button dedicated to fastboot share the same gpio GPIOA13. Led driver is probed early so the corresponding gpio is taken and configured in output which forbid fastboot and stm32prog button usage. To avoid this, remove the "default-state" property from red led node. This will avoid to trigger the led driver probe() to configure the led default state during startup. Signed-off-by: Patrice Chotard <patrice.chotard@foss.st.com> --- arch/arm/dts/stm32mp157c-ed1-scmi-u-boot.dtsi | 1 - 1 file changed, 1 deletion(-)