| Message ID | 20240409150215.2497778-25-patrice.chotard@foss.st.com |
|---|---|
| State | Accepted |
| Commit | aaa486c81112d5b432a5ae7c1e5227f1d780a45d |
| Delegated to: | Patrick Delaunay |
| Headers | show |
| Series | stm32mp: Fix keys & leds management | expand |
Hi, On 4/9/24 17:02, Patrice Chotard wrote: > As indicated in kernel led dt-bindings, label is a deprecated > property, so remove it and use led node's name instead for > u-boot,error-led property. > Rename red led node's name to led-red. > Remove status property which is useless. > Add compatible = "gpio-leds"; which is not present in kernel DT. > > Signed-off-by: Patrice Chotard <patrice.chotard@foss.st.com> > --- > > arch/arm/dts/stm32mp157c-ed1-scmi-u-boot.dtsi | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > Reviewed-by: Patrick Delaunay <patrick.delaunay@foss.st.com> Thanks Patrick
On 4/17/24 11:13, Patrick DELAUNAY wrote: > Hi, > > On 4/9/24 17:02, Patrice Chotard wrote: >> As indicated in kernel led dt-bindings, label is a deprecated >> property, so remove it and use led node's name instead for >> u-boot,error-led property. >> Rename red led node's name to led-red. >> Remove status property which is useless. >> Add compatible = "gpio-leds"; which is not present in kernel DT. >> >> Signed-off-by: Patrice Chotard <patrice.chotard@foss.st.com> >> --- >> >> arch/arm/dts/stm32mp157c-ed1-scmi-u-boot.dtsi | 8 ++++---- >> 1 file changed, 4 insertions(+), 4 deletions(-) >> > > > Reviewed-by: Patrick Delaunay <patrick.delaunay@foss.st.com> > > Thanks > Patrick > Applied on u-boot-stm32/master
diff --git a/arch/arm/dts/stm32mp157c-ed1-scmi-u-boot.dtsi b/arch/arm/dts/stm32mp157c-ed1-scmi-u-boot.dtsi index 2abd512e297..b38e816f888 100644 --- a/arch/arm/dts/stm32mp157c-ed1-scmi-u-boot.dtsi +++ b/arch/arm/dts/stm32mp157c-ed1-scmi-u-boot.dtsi @@ -13,7 +13,7 @@ config { u-boot,boot-led = "heartbeat"; - u-boot,error-led = "error"; + u-boot,error-led = "led-red"; u-boot,mmc-env-partition = "u-boot-env"; }; @@ -34,10 +34,10 @@ }; led { - red { - label = "error"; + compatible = "gpio-leds"; + + led-red { gpios = <&gpioa 13 GPIO_ACTIVE_LOW>; - status = "okay"; }; }; };
As indicated in kernel led dt-bindings, label is a deprecated property, so remove it and use led node's name instead for u-boot,error-led property. Rename red led node's name to led-red. Remove status property which is useless. Add compatible = "gpio-leds"; which is not present in kernel DT. Signed-off-by: Patrice Chotard <patrice.chotard@foss.st.com> --- arch/arm/dts/stm32mp157c-ed1-scmi-u-boot.dtsi | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)