| Message ID | 1553666207-11414-4-git-send-email-skomatineni@nvidia.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | [V1,01/26] spi: tegra114: fix PIO transfer | expand |
On Tue, Mar 26, 2019 at 10:56:25PM -0700, Sowjanya Komatineni wrote: > Fixes: Use packed mode for 32 bits per word transfers to increase > performance as each packet is a full 32-bit word. This is an optimization rather than a bug fix, ideally it should be later in the series to make things easier to apply as fixes for Linus. Also the way you're writing your commit logs with "Fixes: " at the start is really weird and conflicts a bit with the Fixes: tag that the kernel uses to reference the commit that introduces bugs.
> On Tue, Mar 26, 2019 at 10:56:25PM -0700, Sowjanya Komatineni wrote: > > Fixes: Use packed mode for 32 bits per word transfers to increase > > performance as each packet is a full 32-bit word. > > This is an optimization rather than a bug fix, ideally it should be later in the series to make things easier to apply as fixes for Linus. > > Also the way you're writing your commit logs with "Fixes: " at the start is really weird and conflicts a bit with the Fixes: tag that the kernel uses to reference the commit that introduces bugs. Thanks Mark. Misunderstood use of Fixes tag. Will remove Fixes tag in commit message in next version as fixes are not really for specific existing commit.
diff --git a/drivers/spi/spi-tegra114.c b/drivers/spi/spi-tegra114.c index fdba302eb3b6..dc63536dbda4 100644 --- a/drivers/spi/spi-tegra114.c +++ b/drivers/spi/spi-tegra114.c @@ -259,7 +259,7 @@ static unsigned tegra_spi_calculate_curr_xfer_param( tspi->bytes_per_word = DIV_ROUND_UP(bits_per_word, 8); - if (bits_per_word == 8 || bits_per_word == 16) { + if (bits_per_word == 8 || bits_per_word == 16 || bits_per_word == 32) { tspi->is_packed = 1; tspi->words_per_32bit = 32/bits_per_word; } else {
Fixes: Use packed mode for 32 bits per word transfers to increase performance as each packet is a full 32-bit word. Signed-off-by: Sowjanya Komatineni <skomatineni@nvidia.com> --- drivers/spi/spi-tegra114.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)