[V1,12/26] spi: tegra114: add SPI_LSB_FIRST support

Message ID	1553666207-11414-12-git-send-email-skomatineni@nvidia.com
State	Changes Requested
Headers	show Return-Path: <linux-tegra-owner@vger.kernel.org> TLS: TLSv1.2, DES-CBC3-SHA) id <B5c9b10c00000>; Tue, 26 Mar 2019 22:57:20 -0700 From: Sowjanya Komatineni <skomatineni@nvidia.com> To: <thierry.reding@gmail.com>, <jonathanh@nvidia.com>, <talho@nvidia.com>, <skomatineni@nvidia.com>, <broonie@kernel.org>, <robh+dt@kernel.org>, <mark.rutland@arm.com>, <kyarlagadda@nvidia.com> CC: <ldewangan@nvidia.com>, <linux-tegra@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <linux-spi@vger.kernel.org>, <devicetree@vger.kernel.org> Subject: [PATCH V1 12/26] spi: tegra114: add SPI_LSB_FIRST support Date: Tue, 26 Mar 2019 22:56:33 -0700 Message-ID: <1553666207-11414-12-git-send-email-skomatineni@nvidia.com> In-Reply-To: <1553666207-11414-1-git-send-email-skomatineni@nvidia.com> References: <1553666207-11414-1-git-send-email-skomatineni@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-tegra-owner@vger.kernel.org Precedence: bulk
Series	[V1,01/26] spi: tegra114: fix PIO transfer \| expand [V1,01/26] spi: tegra114: fix PIO transfer [V1,02/26] spi: tegra114: clear packed bit for unpacked mode [V1,03/26] spi: tegra114: fix for unpacked mode transfers [V1,04/26] spi: tegra114: use packed mode for 32 bits per word [V1,05/26] spi: tegra114: use unpacked mode for below 4 byte transfers [V1,06/26] spi: tegra114: terminate dma and reset on transfer timeout [V1,07/26] spi: tegra114: flush fifos [V1,08/26] spi: tegra114: configure dma burst size to fifo trig level [V1,09/26] spi: tegra114: dump SPI registers during timeout [V1,10/26] spi: tegra114: avoid reset call in atomic context [V1,11/26] spi: tegra114: reset controller on probe [V1,12/26] spi: tegra114: add SPI_LSB_FIRST support [V1,13/26] spi: tegra114: add dual mode support [V1,14/26] spi: tegra114: add 3 wire transfer mode support [V1,15/26] spi: tegra114: set supported bits_per_word [V1,16/26] spi: tegra114: set bus number based on id [V1,17/26] spi: tegra114: add support for interrupt mask [V1,18/26] spi: tegra114: add support for hw based cs [V1,19/26] DT bindings: spi: add spi client device properties [V1,20/26] spi: tegra114: add support for tuning HW CS timing [V1,21/26] DT bindings: spi: add tx/rx clock delay SPI client properties [V1,22/26] spi: tegra114: add support for tuning clock delay [V1,23/26] spi: tegra114: add support for gpio based cs [V1,24/26] spi: tegra114: de-assert CS before SPI mode is reset to its default [V1,25/26] spi: expand mode and mode_bits support [V1,26/26] spi: tegra114: add support for LSBYTE_FIRST

Message ID

1553666207-11414-12-git-send-email-skomatineni@nvidia.com

State

Changes Requested

Headers

From: Sowjanya Komatineni <skomatineni@nvidia.com>
To: <thierry.reding@gmail.com>, <jonathanh@nvidia.com>,
	<talho@nvidia.com>, <skomatineni@nvidia.com>, <broonie@kernel.org>,
	<robh+dt@kernel.org>, <mark.rutland@arm.com>, <kyarlagadda@nvidia.com>
CC: <ldewangan@nvidia.com>, <linux-tegra@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <linux-spi@vger.kernel.org>,
	<devicetree@vger.kernel.org>
Subject: [PATCH V1 12/26] spi: tegra114: add SPI_LSB_FIRST support
Date: Tue, 26 Mar 2019 22:56:33 -0700
Message-ID: <1553666207-11414-12-git-send-email-skomatineni@nvidia.com>
In-Reply-To: <1553666207-11414-1-git-send-email-skomatineni@nvidia.com>
References: <1553666207-11414-1-git-send-email-skomatineni@nvidia.com>
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-tegra-owner@vger.kernel.org
Precedence: bulk

Series

[V1,01/26] spi: tegra114: fix PIO transfer | expand

Commit Message

Sowjanya Komatineni March 27, 2019, 5:56 a.m. UTC

Tegra SPI controller supports lsb first mode. Default is MSB bit first
and on selection of SPI_LSB_FIRST through SPI mode transmission happens
with LSB bit first.

This patch adds SPI_LSB_FIRST flag to mode_bits and also configures it
on request.

Signed-off-by: Sowjanya Komatineni <skomatineni@nvidia.com>
---
 drivers/spi/spi-tegra114.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/drivers/spi/spi-tegra114.c b/drivers/spi/spi-tegra114.c
index 0e228f1e910e..d39f7b05b824 100644
--- a/drivers/spi/spi-tegra114.c
+++ b/drivers/spi/spi-tegra114.c
@@ -750,6 +750,11 @@  static u32 tegra_spi_setup_transfer_one(struct spi_device *spi,
 		else if (req_mode == SPI_MODE_3)
 			command1 |= SPI_CONTROL_MODE_3;
 
+		if (spi->mode & SPI_LSB_FIRST)
+			command1 |= SPI_LSBIT_FE;
+		else
+			command1 &= ~SPI_LSBIT_FE;
+
 		if (tspi->cs_control) {
 			if (tspi->cs_control != spi)
 				tegra_spi_writel(tspi, command1, SPI_COMMAND1);
@@ -1137,7 +1142,7 @@  static int tegra_spi_probe(struct platform_device *pdev)
 		master->max_speed_hz = 25000000; /* 25MHz */
 
 	/* the spi->mode bits understood by this driver: */
-	master->mode_bits = SPI_CPOL | SPI_CPHA | SPI_CS_HIGH;
+	master->mode_bits = SPI_CPOL | SPI_CPHA | SPI_CS_HIGH | SPI_LSB_FIRST;
 	master->setup = tegra_spi_setup;
 	master->transfer_one_message = tegra_spi_transfer_one_message;
 	master->num_chipselect = MAX_CHIP_SELECT;

[V1,12/26] spi: tegra114: add SPI_LSB_FIRST support

Commit Message

Patch