| Message ID | 20210209171235.20624-4-eajames@linux.ibm.com |
|---|---|
| State | Accepted, archived |
| Headers | show |
| Series | occ: fsi and hwmon: Fixes for polling un-initialized OCC | expand |
On Tue, Feb 09, 2021 at 11:12:34AM -0600, Eddie James wrote: > Initialize the sequence number at one, rather than zero, in order > to prevent false matches with the zero-initialized OCC SRAM > buffer before the OCC is fully initialized. > > Signed-off-by: Eddie James <eajames@linux.ibm.com> Acked-by: Guenter Roeck <linux@roeck-us.net> For now I'll assume that the series has to be submitted together, and that this won't happen through the hwmon branch. Guenter > --- > drivers/hwmon/occ/common.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/hwmon/occ/common.c b/drivers/hwmon/occ/common.c > index 7a5e539b567b..ee0c5d12dfdf 100644 > --- a/drivers/hwmon/occ/common.c > +++ b/drivers/hwmon/occ/common.c > @@ -1150,6 +1150,8 @@ int occ_setup(struct occ *occ, const char *name) > { > int rc; > > + /* start with 1 to avoid false match with zero-initialized SRAM buffer */ > + occ->seq_no = 1; > mutex_init(&occ->lock); > occ->groups[0] = &occ->group; > > -- > 2.27.0 >
diff --git a/drivers/hwmon/occ/common.c b/drivers/hwmon/occ/common.c index 7a5e539b567b..ee0c5d12dfdf 100644 --- a/drivers/hwmon/occ/common.c +++ b/drivers/hwmon/occ/common.c @@ -1150,6 +1150,8 @@ int occ_setup(struct occ *occ, const char *name) { int rc; + /* start with 1 to avoid false match with zero-initialized SRAM buffer */ + occ->seq_no = 1; mutex_init(&occ->lock); occ->groups[0] = &occ->group;
Initialize the sequence number at one, rather than zero, in order to prevent false matches with the zero-initialized OCC SRAM buffer before the OCC is fully initialized. Signed-off-by: Eddie James <eajames@linux.ibm.com> --- drivers/hwmon/occ/common.c | 2 ++ 1 file changed, 2 insertions(+)