| Message ID | 20210209171235.20624-2-eajames@linux.ibm.com |
|---|---|
| State | Accepted, archived |
| Headers | show |
| Series | occ: fsi and hwmon: Fixes for polling un-initialized OCC | expand |
On Tue, 9 Feb 2021 at 17:12, Eddie James <eajames@linux.ibm.com> wrote: > > If the OCC is not initialized and responds as such, the driver > should continue waiting for a valid response until the timeout > expires. > > Signed-off-by: Eddie James <eajames@linux.ibm.com> Reviewed-by: Joel Stanley <joel@jms.id.au> I guess we should add this too? Fixes: 7ed98dddb764 ("fsi: Add On-Chip Controller (OCC) driver") > --- > drivers/fsi/fsi-occ.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/fsi/fsi-occ.c b/drivers/fsi/fsi-occ.c > index 10ca2e290655..cb05b6dacc9d 100644 > --- a/drivers/fsi/fsi-occ.c > +++ b/drivers/fsi/fsi-occ.c > @@ -495,6 +495,7 @@ int fsi_occ_submit(struct device *dev, const void *request, size_t req_len, > goto done; > > if (resp->return_status == OCC_RESP_CMD_IN_PRG || > + resp->return_status == OCC_RESP_CRIT_INIT || > resp->seq_no != seq_no) { > rc = -ETIMEDOUT; > > -- > 2.27.0 >
diff --git a/drivers/fsi/fsi-occ.c b/drivers/fsi/fsi-occ.c index 10ca2e290655..cb05b6dacc9d 100644 --- a/drivers/fsi/fsi-occ.c +++ b/drivers/fsi/fsi-occ.c @@ -495,6 +495,7 @@ int fsi_occ_submit(struct device *dev, const void *request, size_t req_len, goto done; if (resp->return_status == OCC_RESP_CMD_IN_PRG || + resp->return_status == OCC_RESP_CRIT_INIT || resp->seq_no != seq_no) { rc = -ETIMEDOUT;
If the OCC is not initialized and responds as such, the driver should continue waiting for a valid response until the timeout expires. Signed-off-by: Eddie James <eajames@linux.ibm.com> --- drivers/fsi/fsi-occ.c | 1 + 1 file changed, 1 insertion(+)