| Message ID | 20210209171235.20624-5-eajames@linux.ibm.com |
|---|---|
| State | Accepted, archived |
| Headers | show |
| Series | occ: fsi and hwmon: Fixes for polling un-initialized OCC | expand |
On Tue, Feb 09, 2021 at 11:12:35AM -0600, Eddie James wrote: > In order to better debug problems starting up the driver, print > the response status from the OCC in the error logged when the first > poll command fails. > > Signed-off-by: Eddie James <eajames@linux.ibm.com> Acked-by: Guenter Roeck <linux@roeck-us.net> > --- > drivers/hwmon/occ/common.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/hwmon/occ/common.c b/drivers/hwmon/occ/common.c > index ee0c5d12dfdf..f71d62b57468 100644 > --- a/drivers/hwmon/occ/common.c > +++ b/drivers/hwmon/occ/common.c > @@ -1161,8 +1161,9 @@ int occ_setup(struct occ *occ, const char *name) > dev_info(occ->bus_dev, "host is not ready\n"); > return rc; > } else if (rc < 0) { > - dev_err(occ->bus_dev, "failed to get OCC poll response: %d\n", > - rc); > + dev_err(occ->bus_dev, > + "failed to get OCC poll response=%02x: %d\n", > + occ->resp.return_status, rc); > return rc; > } > > -- > 2.27.0 >
diff --git a/drivers/hwmon/occ/common.c b/drivers/hwmon/occ/common.c index ee0c5d12dfdf..f71d62b57468 100644 --- a/drivers/hwmon/occ/common.c +++ b/drivers/hwmon/occ/common.c @@ -1161,8 +1161,9 @@ int occ_setup(struct occ *occ, const char *name) dev_info(occ->bus_dev, "host is not ready\n"); return rc; } else if (rc < 0) { - dev_err(occ->bus_dev, "failed to get OCC poll response: %d\n", - rc); + dev_err(occ->bus_dev, + "failed to get OCC poll response=%02x: %d\n", + occ->resp.return_status, rc); return rc; }
In order to better debug problems starting up the driver, print the response status from the OCC in the error logged when the first poll command fails. Signed-off-by: Eddie James <eajames@linux.ibm.com> --- drivers/hwmon/occ/common.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)