| Message ID | 1522142971-20739-19-git-send-email-kever.yang@rock-chips.com |
|---|---|
| State | Changes Requested |
| Delegated to: | Philipp Tomsich |
| Headers | show |
| Series | rockchip: clean up board file for rockchip SoCs | expand |
> We use ARM arch timer instead. > > Signed-off-by: Kever Yang <kever.yang@rock-chips.com> > --- > > include/configs/rk3188_common.h | 3 --- > 1 file changed, 3 deletions(-) > Acked-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
On Tue, 27 Mar 2018, Kever Yang wrote: > We use ARM arch timer instead. > > Signed-off-by: Kever Yang <kever.yang@rock-chips.com> > --- > > include/configs/rk3188_common.h | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/include/configs/rk3188_common.h b/include/configs/rk3188_common.h > index 30c150e..7dddf11 100644 > --- a/include/configs/rk3188_common.h > +++ b/include/configs/rk3188_common.h > @@ -17,9 +17,6 @@ > #define CONFIG_SYS_MALLOC_LEN (32 << 20) > #define CONFIG_SYS_CBSIZE 1024 > > -#define CONFIG_SYS_TIMER_RATE (24 * 1000 * 1000) > -#define CONFIG_SYS_TIMER_BASE 0x2000e000 /* TIMER3 */ > -#define CONFIG_SYS_TIMER_COUNTER (CONFIG_SYS_TIMER_BASE + 8) > #define CONFIG_SYS_TIMER_COUNTS_DOWN > > #ifdef CONFIG_SPL_ROCKCHIP_BACK_TO_BROM >
On Sun, Apr 01, 2018 at 10:21:50PM +0200, Philipp Tomsich wrote: > > We use ARM arch timer instead. > > > > Signed-off-by: Kever Yang <kever.yang@rock-chips.com> > > --- > > > > include/configs/rk3188_common.h | 3 --- > > 1 file changed, 3 deletions(-) > > > > Acked-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com> fwiw., i don't believe rk3188(Cortex-A9) has the armv7 'arch timer'. please do test before applying.. -Artturi > _______________________________________________ > U-Boot mailing list > U-Boot@lists.denx.de > https://lists.denx.de/listinfo/u-boot
Arturri, > On 2 Apr 2018, at 11:38, Artturi Alm <artturi.alm@gmail.com> wrote: > > On Sun, Apr 01, 2018 at 10:21:50PM +0200, Philipp Tomsich wrote: >>> We use ARM arch timer instead. >>> >>> Signed-off-by: Kever Yang <kever.yang@rock-chips.com> >>> --- >>> >>> include/configs/rk3188_common.h | 3 --- >>> 1 file changed, 3 deletions(-) >>> >> >> Acked-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com> > > fwiw., i don't believe rk3188(Cortex-A9) has the armv7 'arch timer'. > please do test before applying.. I won’t be able to test this one (and a number other ones), as I only have access to RK3399 and RK3368 boards. Feel free to validate this on your end and comment on this patch. This patch set is not on my list for the current release cycle, due to it affecting all boards and the associated test effort needed. I am considering either for a ‘next’-branch or for a topic-branch to be created later in this cycle (e.g. branched off rc2?). Thanks, Philipp.
Am Montag, 2. April 2018, 11:51:30 CEST schrieb Dr. Philipp Tomsich: > Arturri, > > > On 2 Apr 2018, at 11:38, Artturi Alm <artturi.alm@gmail.com> wrote: > > > > On Sun, Apr 01, 2018 at 10:21:50PM +0200, Philipp Tomsich wrote: > >>> We use ARM arch timer instead. > >>> > >>> Signed-off-by: Kever Yang <kever.yang@rock-chips.com> > >>> --- > >>> > >>> include/configs/rk3188_common.h | 3 --- > >>> 1 file changed, 3 deletions(-) > >>> > >> > >> Acked-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com> > > > > fwiw., i don't believe rk3188(Cortex-A9) has the armv7 'arch timer'. > > please do test before applying.. > > I won’t be able to test this one (and a number other ones), as I only > have access to RK3399 and RK3368 boards. > > Feel free to validate this on your end and comment on this patch. > > This patch set is not on my list for the current release cycle, due to > it affecting all boards and the associated test effort needed. I am > considering either for a ‘next’-branch or for a topic-branch to be > created later in this cycle (e.g. branched off rc2?). Cortex-A9 socs like the rk3188 (and rk3066) do not have an architected timer. That was only introduced with the following ARM cores. So the timer support should probably stay around Heiko
diff --git a/include/configs/rk3188_common.h b/include/configs/rk3188_common.h index 30c150e..7dddf11 100644 --- a/include/configs/rk3188_common.h +++ b/include/configs/rk3188_common.h @@ -17,9 +17,6 @@ #define CONFIG_SYS_MALLOC_LEN (32 << 20) #define CONFIG_SYS_CBSIZE 1024 -#define CONFIG_SYS_TIMER_RATE (24 * 1000 * 1000) -#define CONFIG_SYS_TIMER_BASE 0x2000e000 /* TIMER3 */ -#define CONFIG_SYS_TIMER_COUNTER (CONFIG_SYS_TIMER_BASE + 8) #define CONFIG_SYS_TIMER_COUNTS_DOWN #ifdef CONFIG_SPL_ROCKCHIP_BACK_TO_BROM
We use ARM arch timer instead. Signed-off-by: Kever Yang <kever.yang@rock-chips.com> --- include/configs/rk3188_common.h | 3 --- 1 file changed, 3 deletions(-)