Message ID | 20180917163103.6113-6-cota@braap.org |
---|---|
State | New |
Headers | show |
Series | exec: drop BQL from interrupt handling | expand |
Am 17.09.18 um 18:30 schrieb Emilio G. Cota: > From: Paolo Bonzini <pbonzini@redhat.com> > > It will be changed to an atomic operation soon. > > Cc: Cornelia Huck <cohuck@redhat.com> > Cc: Richard Henderson <rth@twiddle.net> > Cc: Alexander Graf <agraf@suse.de> > Cc: David Hildenbrand <david@redhat.com> > Cc: qemu-s390x@nongnu.org > Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> > Signed-off-by: Emilio G. Cota <cota@braap.org> > --- > target/s390x/excp_helper.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/target/s390x/excp_helper.c b/target/s390x/excp_helper.c > index f0ce60cff2..f2b92d7cbc 100644 > --- a/target/s390x/excp_helper.c > +++ b/target/s390x/excp_helper.c > @@ -444,7 +444,7 @@ try_deliver: > > /* we might still have pending interrupts, but not deliverable */ > if (!env->pending_int && !qemu_s390_flic_has_any(flic)) { > - cs->interrupt_request &= ~CPU_INTERRUPT_HARD; > + cpu_reset_interrupt(cs, CPU_INTERRUPT_HARD); > } > > /* WAIT PSW during interrupt injection or STOP interrupt */ > Reviewed-by: David Hildenbrand <david@redhat.com>
On 9/17/18 9:30 AM, Emilio G. Cota wrote: > From: Paolo Bonzini <pbonzini@redhat.com> > > It will be changed to an atomic operation soon. > > Cc: Cornelia Huck <cohuck@redhat.com> > Cc: Richard Henderson <rth@twiddle.net> > Cc: Alexander Graf <agraf@suse.de> > Cc: David Hildenbrand <david@redhat.com> > Cc: qemu-s390x@nongnu.org > Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> > Signed-off-by: Emilio G. Cota <cota@braap.org> > --- > target/s390x/excp_helper.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Richard Henderson <richard.henderson@linaro.org> r~
On Mon, 17 Sep 2018 12:30:33 -0400 "Emilio G. Cota" <cota@braap.org> wrote: > From: Paolo Bonzini <pbonzini@redhat.com> > > It will be changed to an atomic operation soon. > > Cc: Cornelia Huck <cohuck@redhat.com> > Cc: Richard Henderson <rth@twiddle.net> > Cc: Alexander Graf <agraf@suse.de> > Cc: David Hildenbrand <david@redhat.com> > Cc: qemu-s390x@nongnu.org > Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> > Signed-off-by: Emilio G. Cota <cota@braap.org> > --- > target/s390x/excp_helper.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: Cornelia Huck <cohuck@redhat.com>
diff --git a/target/s390x/excp_helper.c b/target/s390x/excp_helper.c index f0ce60cff2..f2b92d7cbc 100644 --- a/target/s390x/excp_helper.c +++ b/target/s390x/excp_helper.c @@ -444,7 +444,7 @@ try_deliver: /* we might still have pending interrupts, but not deliverable */ if (!env->pending_int && !qemu_s390_flic_has_any(flic)) { - cs->interrupt_request &= ~CPU_INTERRUPT_HARD; + cpu_reset_interrupt(cs, CPU_INTERRUPT_HARD); } /* WAIT PSW during interrupt injection or STOP interrupt */