Message ID | 20180917163103.6113-32-cota@braap.org |
---|---|
State | New |
Headers | show |
Series | exec: drop BQL from interrupt handling | expand |
On 9/17/18 9:30 AM, Emilio G. Cota wrote: > This patch explicitly drops the BQL assertion from > the user-mode version; previous patches have taken > care of softmmu's cpu_interrupt. > > Cc: Peter Crosthwaite <crosthwaite.peter@gmail.com> > Cc: Richard Henderson <rth@twiddle.net> > Signed-off-by: Emilio G. Cota <cota@braap.org> > --- > accel/tcg/translate-all.c | 1 - > 1 file changed, 1 deletion(-) Reviewed-by: Richard Henderson <richard.henderson@linaro.org> r~
On 9/17/18 6:30 PM, Emilio G. Cota wrote: > This patch explicitly drops the BQL assertion from > the user-mode version; previous patches have taken > care of softmmu's cpu_interrupt. > > Cc: Peter Crosthwaite <crosthwaite.peter@gmail.com> > Cc: Richard Henderson <rth@twiddle.net> > Signed-off-by: Emilio G. Cota <cota@braap.org> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org> > --- > accel/tcg/translate-all.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/accel/tcg/translate-all.c b/accel/tcg/translate-all.c > index 364757c677..911436a8d7 100644 > --- a/accel/tcg/translate-all.c > +++ b/accel/tcg/translate-all.c > @@ -2350,7 +2350,6 @@ void dump_opcount_info(FILE *f, fprintf_function cpu_fprintf) > > void cpu_interrupt(CPUState *cpu, int mask) > { > - g_assert(qemu_mutex_iothread_locked()); > atomic_or(&cpu->interrupt_request, mask); > atomic_set(&cpu->icount_decr.u16.high, -1); > } >
diff --git a/accel/tcg/translate-all.c b/accel/tcg/translate-all.c index 364757c677..911436a8d7 100644 --- a/accel/tcg/translate-all.c +++ b/accel/tcg/translate-all.c @@ -2350,7 +2350,6 @@ void dump_opcount_info(FILE *f, fprintf_function cpu_fprintf) void cpu_interrupt(CPUState *cpu, int mask) { - g_assert(qemu_mutex_iothread_locked()); atomic_or(&cpu->interrupt_request, mask); atomic_set(&cpu->icount_decr.u16.high, -1); }
This patch explicitly drops the BQL assertion from the user-mode version; previous patches have taken care of softmmu's cpu_interrupt. Cc: Peter Crosthwaite <crosthwaite.peter@gmail.com> Cc: Richard Henderson <rth@twiddle.net> Signed-off-by: Emilio G. Cota <cota@braap.org> --- accel/tcg/translate-all.c | 1 - 1 file changed, 1 deletion(-)