diff mbox series

[03/12] i2c: designware_i2c: Include clk.h in the header file

Message ID 20191221161525.27976-4-sjg@chromium.org
State Superseded
Delegated to: Heiko Schocher
Headers show
Series i2c: designware_ic2: Improvements to timing | expand

Commit Message

Simon Glass Dec. 21, 2019, 4:15 p.m. UTC
We use struct clk here so really should include this header file to avoid
build errors. Also switch the order of clk.h in the C file to match the
required code style.

Signed-off-by: Simon Glass <sjg@chromium.org>
---

 drivers/i2c/designware_i2c.c | 2 +-
 drivers/i2c/designware_i2c.h | 1 +
 2 files changed, 2 insertions(+), 1 deletion(-)

Comments

Ley Foon Tan Dec. 23, 2019, 8:17 a.m. UTC | #1
> -----Original Message-----
> From: Simon Glass <sjg@chromium.org>
> Sent: Sunday, December 22, 2019 12:15 AM
> To: U-Boot Mailing List <u-boot@lists.denx.de>
> Cc: Jun Chen <ptchentw@gmail.com>; Heiko Schocher <hs@denx.de>; Tan,
> Ley Foon <ley.foon.tan@intel.com>; Simon Glass <sjg@chromium.org>
> Subject: [PATCH 03/12] i2c: designware_i2c: Include clk.h in the header file
> 
> We use struct clk here so really should include this header file to avoid build
> errors. Also switch the order of clk.h in the C file to match the required code
> style.
> 
> Signed-off-by: Simon Glass <sjg@chromium.org>

Reviewed-by: Ley Foon Tan <ley.foon.tan@intel.com>
> ---
> 
>  drivers/i2c/designware_i2c.c | 2 +-
>  drivers/i2c/designware_i2c.h | 1 +
>  2 files changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/i2c/designware_i2c.c b/drivers/i2c/designware_i2c.c
> index b8cdd1c661..138fc72561 100644
> --- a/drivers/i2c/designware_i2c.c
> +++ b/drivers/i2c/designware_i2c.c
> @@ -4,8 +4,8 @@
>   * Vipin Kumar, ST Micoelectronics, vipin.kumar@st.com.
>   */
> 
> -#include <clk.h>
>  #include <common.h>
> +#include <clk.h>
>  #include <dm.h>
>  #include <i2c.h>
>  #include <pci.h>
> diff --git a/drivers/i2c/designware_i2c.h b/drivers/i2c/designware_i2c.h
> index 0eb28191d2..39e62bcf51 100644
> --- a/drivers/i2c/designware_i2c.h
> +++ b/drivers/i2c/designware_i2c.h
> @@ -7,6 +7,7 @@
>  #ifndef __DW_I2C_H_
>  #define __DW_I2C_H_
> 
> +#include <clk.h>
>  #include <reset.h>
> 
>  struct i2c_regs {
> --
> 2.24.1.735.g03f4e72817-goog
diff mbox series

Patch

diff --git a/drivers/i2c/designware_i2c.c b/drivers/i2c/designware_i2c.c
index b8cdd1c661..138fc72561 100644
--- a/drivers/i2c/designware_i2c.c
+++ b/drivers/i2c/designware_i2c.c
@@ -4,8 +4,8 @@ 
  * Vipin Kumar, ST Micoelectronics, vipin.kumar@st.com.
  */
 
-#include <clk.h>
 #include <common.h>
+#include <clk.h>
 #include <dm.h>
 #include <i2c.h>
 #include <pci.h>
diff --git a/drivers/i2c/designware_i2c.h b/drivers/i2c/designware_i2c.h
index 0eb28191d2..39e62bcf51 100644
--- a/drivers/i2c/designware_i2c.h
+++ b/drivers/i2c/designware_i2c.h
@@ -7,6 +7,7 @@ 
 #ifndef __DW_I2C_H_
 #define __DW_I2C_H_
 
+#include <clk.h>
 #include <reset.h>
 
 struct i2c_regs {