[02/12] i2c: designware_i2c: Don't allow changing IC_CLK

Message ID	20191221161525.27976-3-sjg@chromium.org
State	Superseded
Delegated to:	Heiko Schocher
Headers	show Return-Path: <u-boot-bounces@lists.denx.de> From: Simon Glass <sjg@chromium.org> To: U-Boot Mailing List <u-boot@lists.denx.de> Subject: [PATCH 02/12] i2c: designware_i2c: Don't allow changing IC_CLK Date: Sat, 21 Dec 2019 09:15:15 -0700 Message-Id: <20191221161525.27976-3-sjg@chromium.org> In-Reply-To: <20191221161525.27976-1-sjg@chromium.org> References: <20191221161525.27976-1-sjg@chromium.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: list Cc: Jun Chen <ptchentw@gmail.com> Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" <u-boot-bounces@lists.denx.de>
Series	i2c: designware_ic2: Improvements to timing \| expand [00/12] i2c: designware_ic2: Improvements to timing [01/12] i2c: designware_i2c: Add more registers [02/12] i2c: designware_i2c: Don't allow changing IC_CLK [03/12] i2c: designware_i2c: Include clk.h in the header file [04/12] i2c: designware_i2c: Rename 'max' speed to 'high' speed [05/12] i2c: designware_i2c: Use an enum for selected speed mode [06/12] i2c: designware_i2c: Use an accurate bus clock instead of MHz [07/12] i2c: designware_i2c: Bring in the binding file [08/12] i2c: designware_i2c: Read device-tree properties [09/12] i2c: designware_i2c: Drop scl_sda_cfg parameter [10/12] i2c: designware_i2c: Put hold config in a struct [11/12] i2c: designware_i2c: Rewrite timing calculation [12/12] i2c: designware_i2c: Add spike supression

Message ID

20191221161525.27976-3-sjg@chromium.org

State

Superseded

Delegated to:

Heiko Schocher

Headers

From: Simon Glass <sjg@chromium.org>
To: U-Boot Mailing List <u-boot@lists.denx.de>
Subject: [PATCH 02/12] i2c: designware_i2c: Don't allow changing IC_CLK
Date: Sat, 21 Dec 2019 09:15:15 -0700
Message-Id: <20191221161525.27976-3-sjg@chromium.org>
In-Reply-To: <20191221161525.27976-1-sjg@chromium.org>
References: <20191221161525.27976-1-sjg@chromium.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: list
Cc: Jun Chen <ptchentw@gmail.com>
Errors-To: u-boot-bounces@lists.denx.de
Sender: "U-Boot" <u-boot-bounces@lists.denx.de>

Series

i2c: designware_ic2: Improvements to timing | expand

Commit Message

Simon Glass Dec. 21, 2019, 4:15 p.m. UTC

If a different input clock is required then the correct way to do this is
with a clock driver. Don't allow boards to override IC_CLK.

Signed-off-by: Simon Glass <sjg@chromium.org>
---

 drivers/i2c/designware_i2c.h | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/i2c/designware_i2c.h b/drivers/i2c/designware_i2c.h
index d359c8c3f8..0eb28191d2 100644
--- a/drivers/i2c/designware_i2c.h
+++ b/drivers/i2c/designware_i2c.h
@@ -58,9 +58,7 @@  struct i2c_regs {
 	u32 comp_type;
 };
 
-#if !defined(IC_CLK)
 #define IC_CLK			166
-#endif
 #define NANO_TO_MICRO		1000
 
 /* High and low times in different speed modes (in ns) */

[02/12] i2c: designware_i2c: Don't allow changing IC_CLK

Commit Message

Patch