| Message ID | 20170423064708.10159-1-yann.morin.1998@free.fr |
|---|---|
| State | Accepted |
| Headers | show |
Am Sun, 23 Apr 2017 08:47:08 +0200 schrieb Yann E. MORIN: > Do for the init script what was done two years ago for the service file. Reviewed-by: Bernd Kuhls <bernd.kuhls@t-online.de>
Bernd, All, On 2017-04-23 09:03 +0200, Bernd Kuhls spake thusly: > Am Sun, 23 Apr 2017 08:47:08 +0200 schrieb Yann E. MORIN: > > Do for the init script what was done two years ago for the service file. > Reviewed-by: Bernd Kuhls <bernd.kuhls@t-online.de> Thanks! I just saw that you had already reviewed the previous iteration. But because you do not Cc the author when replying, I missed it. Could you, please, follow the usual practice that we follow on this mailing list (and the usual practice followed about everywhere on every mailing lists) to reply by mail with the author and the list as recipient, please? Regards, Yann E. MORIN.
Hello, On Sun, 23 Apr 2017 08:47:08 +0200, Yann E. MORIN wrote: > Since XBMC was renamed to Kodi, upstream is progressively propagating > the rename to directories and files, and in some cases kept a legacy > symlink xbmc->kodi, like /usr/lib/xbmc pointing to /usr/lib/kodi. > > In 62165ae (package/kodi: Fix path to binary in service), the path was > changed to use the new canonical path, but the init script was left out. > This was not seen previously, because of the legacy symlink. > > But with the advent of Kodi 17 (Krypton), that legacy symlink is no > more, and the init script no longer works. > > Do for the init script what was done two years ago for the service file. > > Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr> > Cc: Maxime Hadjinlian <maxime.hadjinlian@gmail.com> > Cc: Bernd Kuhls <bernd.kuhls@t-online.de> > Cc: Marcus Hoffmann <m.hoffmann@cartelsol.com> > > --- > Changes v1 -> v2: > - typoes (Marcus) > --- > package/kodi/S50kodi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied to master, thanks. Thomas
diff --git a/package/kodi/S50kodi b/package/kodi/S50kodi index f00c59c5d9..0afe7a6706 100755 --- a/package/kodi/S50kodi +++ b/package/kodi/S50kodi @@ -4,7 +4,7 @@ # BIN=/usr/bin/br-kodi -KODI=/usr/lib/xbmc/kodi.bin +KODI=/usr/lib/kodi/kodi.bin KODI_ARGS="--standalone -fs -n" PIDFILE=/var/run/kodi.pid
Since XBMC was renamed to Kodi, upstream is progressively propagating the rename to directories and files, and in some cases kept a legacy symlink xbmc->kodi, like /usr/lib/xbmc pointing to /usr/lib/kodi. In 62165ae (package/kodi: Fix path to binary in service), the path was changed to use the new canonical path, but the init script was left out. This was not seen previously, because of the legacy symlink. But with the advent of Kodi 17 (Krypton), that legacy symlink is no more, and the init script no longer works. Do for the init script what was done two years ago for the service file. Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr> Cc: Maxime Hadjinlian <maxime.hadjinlian@gmail.com> Cc: Bernd Kuhls <bernd.kuhls@t-online.de> Cc: Marcus Hoffmann <m.hoffmann@cartelsol.com> --- Changes v1 -> v2: - typoes (Marcus) --- package/kodi/S50kodi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)