diff mbox series

[v1,13/24] board: colibri-imx6ull: Do not leave variant variable unset

Message ID 20220408080719.342072-14-marcel@ziswiler.com
State Accepted
Commit 885dcc36afe80f5d0e56ee540787fee5102ac601
Delegated to: Stefano Babic
Headers show
Series toradex updates: assortment of fixes and improvements | expand

Commit Message

Marcel Ziswiler April 8, 2022, 8:07 a.m. UTC 
From: Philippe Schenker <philippe.schenker@toradex.com>

Toradex uses the variable variant to distinguish between modules with
eMMC, NAND with wifi and NAND without wifi.
This variable is set on every boot. Set this variable also if we have a
NAND module without wifi to prevent issues.

Signed-off-by: Philippe Schenker <philippe.schenker@toradex.com>
Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
---

 board/toradex/colibri-imx6ull/colibri-imx6ull.c | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Stefano Babic April 12, 2022, 6:47 p.m. UTC | #1 
> From: Philippe Schenker <philippe.schenker@toradex.com>
> Toradex uses the variable variant to distinguish between modules with
> eMMC, NAND with wifi and NAND without wifi.
> This variable is set on every boot. Set this variable also if we have a
> NAND module without wifi to prevent issues.
> Signed-off-by: Philippe Schenker <philippe.schenker@toradex.com>
> Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic
diff mbox series

Patch

diff --git a/board/toradex/colibri-imx6ull/colibri-imx6ull.c b/board/toradex/colibri-imx6ull/colibri-imx6ull.c
index 02ab5889b9a..3244184f272 100644
--- a/board/toradex/colibri-imx6ull/colibri-imx6ull.c
+++ b/board/toradex/colibri-imx6ull/colibri-imx6ull.c
@@ -172,10 +172,14 @@  int board_late_init(void)
 	} else {
 		if (is_emmc)
 			env_set("variant", "-emmc");
+		else
+			env_set("variant", "");
 	}
 #else
 	if (is_emmc)
 		env_set("variant", "-emmc");
+	else
+		env_set("variant", "");
 #endif
 
 	/*