diff mbox series

[v1,12/24] apalis-tk1: avoid save environment unasked

Message ID 20220408080719.342072-13-marcel@ziswiler.com
State Accepted
Commit c1e6576162a8c360e41ce03f7b1364e408cae8f0
Delegated to: Stefano Babic
Headers show
Series toradex updates: assortment of fixes and improvements | expand

Commit Message

Marcel Ziswiler April 8, 2022, 8:07 a.m. UTC 
From: Denys Drozdov <denys.drozdov@toradex.com>

U-Boot should never save the environment unasked.
This also avoids storing broken fdt_module to flash.

Signed-off-by: Denys Drozdov <denys.drozdov@toradex.com>
Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
---

 board/toradex/apalis-tk1/apalis-tk1.c | 3 ---
 1 file changed, 3 deletions(-)

Comments

Stefano Babic April 12, 2022, 6:42 p.m. UTC | #1 
> From: Denys Drozdov <denys.drozdov@toradex.com>
> U-Boot should never save the environment unasked.
> This also avoids storing broken fdt_module to flash.
> Signed-off-by: Denys Drozdov <denys.drozdov@toradex.com>
> Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic
diff mbox series

Patch

diff --git a/board/toradex/apalis-tk1/apalis-tk1.c b/board/toradex/apalis-tk1/apalis-tk1.c
index 2769b546010..ccf665b2118 100644
--- a/board/toradex/apalis-tk1/apalis-tk1.c
+++ b/board/toradex/apalis-tk1/apalis-tk1.c
@@ -71,9 +71,6 @@  int arch_misc_init(void)
 			env_set("fdt_module", FDT_MODULE_V1_0);
 			printf("patching fdt_module to " FDT_MODULE_V1_0
 			       " for older V1.0 and V1.1 HW\n");
-#ifndef CONFIG_ENV_IS_NOWHERE
-			env_save();
-#endif
 		}
 
 		/* activate USB power enable GPIOs */