diff mbox series

[v1,11/24] apalis-imx6: avoid save environment unasked

Message ID 20220408080719.342072-12-marcel@ziswiler.com
State Accepted
Commit b8055ee1762b291db56dd1df107dd778df94c717
Delegated to: Stefano Babic
Headers show
Series toradex updates: assortment of fixes and improvements | expand

Commit Message

Marcel Ziswiler April 8, 2022, 8:07 a.m. UTC 
From: Denys Drozdov <denys.drozdov@toradex.com>

U-Boot should never save the environment unasked.
This also avoids storing broken ftd_file to eMMC.

Signed-off-by: Denys Drozdov <denys.drozdov@toradex.com>
Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
---

 board/toradex/apalis_imx6/apalis_imx6.c | 3 ---
 1 file changed, 3 deletions(-)

Comments

Stefano Babic April 12, 2022, 6:48 p.m. UTC | #1 
> From: Denys Drozdov <denys.drozdov@toradex.com>
> U-Boot should never save the environment unasked.
> This also avoids storing broken ftd_file to eMMC.
> Signed-off-by: Denys Drozdov <denys.drozdov@toradex.com>
> Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic
diff mbox series

Patch

diff --git a/board/toradex/apalis_imx6/apalis_imx6.c b/board/toradex/apalis_imx6/apalis_imx6.c
index 25a4cd9f38b..a78d52d3fac 100644
--- a/board/toradex/apalis_imx6/apalis_imx6.c
+++ b/board/toradex/apalis_imx6/apalis_imx6.c
@@ -727,9 +727,6 @@  int board_late_init(void)
 		if ((fdt_env != NULL) && (strcmp(FDT_FILE, fdt_env) == 0)) {
 			env_set("fdt_file", FDT_FILE_V1_0);
 			printf("patching fdt_file to " FDT_FILE_V1_0 "\n");
-#ifndef CONFIG_ENV_IS_NOWHERE
-			env_save();
-#endif
 		}
 	}
 #endif /* CONFIG_TDX_APALIS_IMX6_V1_0 */