diff mbox series

[02/27] imx: imx8ulp: include pcc/cgc header in clock header

Message ID 20220214124735.25580-3-peng.fan@oss.nxp.com
State Superseded
Delegated to: Stefano Babic
Headers show
Series imx: imx8ulp: misc update from downstream | expand

Commit Message

Peng Fan (OSS) Feb. 14, 2022, 12:47 p.m. UTC 
From: Peng Fan <peng.fan@nxp.com>

Only including clock.h could simplify header files.

Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
 arch/arm/include/asm/arch-imx8ulp/clock.h | 3 +++
 1 file changed, 3 insertions(+)

Comments

Fabio Estevam Feb. 26, 2022, 1:34 p.m. UTC | #1 
On Mon, Feb 14, 2022 at 9:08 AM Peng Fan (OSS) <peng.fan@oss.nxp.com> wrote:
>
> From: Peng Fan <peng.fan@nxp.com>
>
> Only including clock.h could simplify header files.

Sorry, I don't understand this commit log.

> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
>  arch/arm/include/asm/arch-imx8ulp/clock.h | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/arch/arm/include/asm/arch-imx8ulp/clock.h b/arch/arm/include/asm/arch-imx8ulp/clock.h
> index c0f32cc087..d7c92f7058 100644
> --- a/arch/arm/include/asm/arch-imx8ulp/clock.h
> +++ b/arch/arm/include/asm/arch-imx8ulp/clock.h
> @@ -6,6 +6,9 @@
>  #ifndef _ASM_ARCH_IMX8ULP_CLOCK_H
>  #define _ASM_ARCH_IMX8ULP_CLOCK_H
>
> +#include <asm/arch/pcc.h>
> +#include <asm/arch/cgc.h>

Please explain why you need to include these two header files.
Peng Fan (OSS) March 4, 2022, 7:17 a.m. UTC | #2 
On 2022/2/26 21:34, Fabio Estevam wrote:
> On Mon, Feb 14, 2022 at 9:08 AM Peng Fan (OSS) <peng.fan@oss.nxp.com> wrote:
>>
>> From: Peng Fan <peng.fan@nxp.com>
>>
>> Only including clock.h could simplify header files.
> 
> Sorry, I don't understand this commit log.
> 
>> Signed-off-by: Peng Fan <peng.fan@nxp.com>
>> ---
>>   arch/arm/include/asm/arch-imx8ulp/clock.h | 3 +++
>>   1 file changed, 3 insertions(+)
>>
>> diff --git a/arch/arm/include/asm/arch-imx8ulp/clock.h b/arch/arm/include/asm/arch-imx8ulp/clock.h
>> index c0f32cc087..d7c92f7058 100644
>> --- a/arch/arm/include/asm/arch-imx8ulp/clock.h
>> +++ b/arch/arm/include/asm/arch-imx8ulp/clock.h
>> @@ -6,6 +6,9 @@
>>   #ifndef _ASM_ARCH_IMX8ULP_CLOCK_H
>>   #define _ASM_ARCH_IMX8ULP_CLOCK_H
>>
>> +#include <asm/arch/pcc.h>
>> +#include <asm/arch/cgc.h>
> 
> Please explain why you need to include these two header files.

No need to include pcc/cgc header file both for users, only need
include clock.h

Thanks,
Peng.

>
diff mbox series

Patch

diff --git a/arch/arm/include/asm/arch-imx8ulp/clock.h b/arch/arm/include/asm/arch-imx8ulp/clock.h
index c0f32cc087..d7c92f7058 100644
--- a/arch/arm/include/asm/arch-imx8ulp/clock.h
+++ b/arch/arm/include/asm/arch-imx8ulp/clock.h
@@ -6,6 +6,9 @@ 
 #ifndef _ASM_ARCH_IMX8ULP_CLOCK_H
 #define _ASM_ARCH_IMX8ULP_CLOCK_H
 
+#include <asm/arch/pcc.h>
+#include <asm/arch/cgc.h>
+
 /* Mainly for compatible to imx common code. */
 enum mxc_clock {
 	MXC_ARM_CLK = 0,