diff mbox series

[4/6] Testsuite: Make it easier to debug environment setting functions

Message ID 20200709095631.GA5981@arm.com
State New
Headers show
Series [1/6] AArch64: Fix bugs in -mcpu=native detection. | expand

Commit Message

Tamar Christina July 9, 2020, 9:56 a.m. UTC 
Hi All,

This adds verbose output to dg-set-compiler-env-var and dg-set-target-env-var
so you can actually see what they're setting when you add -v -v.

Bootstrapped Regtested on aarch64-none-linux-gnu and no issues.

Ok for master?

Thanks,
Tamar

gcc/testsuite/ChangeLog:

	* lib/gcc-dg.exp (dg-set-compiler-env-var, dg-set-target-env-var): Add
	verbose output.

--

Comments

Mike Stump July 9, 2020, 5:24 p.m. UTC | #1 
On Jul 9, 2020, at 2:56 AM, Tamar Christina <Tamar.Christina@arm.com> wrote:
> This adds verbose output to dg-set-compiler-env-var and dg-set-target-env-var
> so you can actually see what they're setting when you add -v -v.
> 
> Bootstrapped Regtested on aarch64-none-linux-gnu and no issues.
> 
> Ok for master?

Ok.
Richard Sandiford July 9, 2020, 5:34 p.m. UTC | #2 
Tamar Christina <tamar.christina@arm.com> writes:
> diff --git a/gcc/testsuite/lib/gcc-dg.exp b/gcc/testsuite/lib/gcc-dg.exp
> index 27cc7c19625d8bff12268de16ec0c20d558394b7..ccf6b7cc70b1d4268c0b0c65f960fb42deab0d88 100644
> --- a/gcc/testsuite/lib/gcc-dg.exp
> +++ b/gcc/testsuite/lib/gcc-dg.exp
> @@ -477,7 +477,10 @@ proc dg-set-target-env-var { args } {
>  	error "dg-set-target-env-var: need two arguments"
>  	return
>      }
> -    lappend set_target_env_var [list [lindex $args 1] [lindex $args 2]]
> +    set var [lindex $args 1]
> +    set value [lindex $args 2]
> +    verbose "dg-set-compiler-env-var $var $value" 2

“dg-set-target-env-var”

OK with that change, thanks.

Richard

> +    lappend set_target_env_var [list $var $value]
>  }
 
>  proc set-target-env-var { } {
> @@ -518,6 +521,7 @@ proc dg-set-compiler-env-var { args } {
>      }
>      set var [lindex $args 1]
>      set value [lindex $args 2]
> +    verbose "dg-set-compiler-env-var $var $value" 2
>      if [info exists ::env($var)] {
>        lappend saved_compiler_env_var [list $var 1 $::env($var)]
>      } else {
Li, Pan2 via Gcc-patches July 10, 2020, 9:06 p.m. UTC | #3 
On Thu, 2020-07-09 at 10:56 +0100, Tamar Christina wrote:
> Hi All,
> 
> This adds verbose output to dg-set-compiler-env-var and dg-set-target-env-var
> so you can actually see what they're setting when you add -v -v.
> 
> Bootstrapped Regtested on aarch64-none-linux-gnu and no issues.
> 
> Ok for master?
> 
> Thanks,
> Tamar
> 
> gcc/testsuite/ChangeLog:
> 
> 	* lib/gcc-dg.exp (dg-set-compiler-env-var, dg-set-target-env-var): Add
> 	verbose output.
OK
jeff
diff mbox series

Patch

diff --git a/gcc/testsuite/lib/gcc-dg.exp b/gcc/testsuite/lib/gcc-dg.exp
index 27cc7c19625d8bff12268de16ec0c20d558394b7..ccf6b7cc70b1d4268c0b0c65f960fb42deab0d88 100644
--- a/gcc/testsuite/lib/gcc-dg.exp
+++ b/gcc/testsuite/lib/gcc-dg.exp
@@ -477,7 +477,10 @@  proc dg-set-target-env-var { args } {
 	error "dg-set-target-env-var: need two arguments"
 	return
     }
-    lappend set_target_env_var [list [lindex $args 1] [lindex $args 2]]
+    set var [lindex $args 1]
+    set value [lindex $args 2]
+    verbose "dg-set-compiler-env-var $var $value" 2
+    lappend set_target_env_var [list $var $value]
 }
 
 proc set-target-env-var { } {
@@ -518,6 +521,7 @@  proc dg-set-compiler-env-var { args } {
     }
     set var [lindex $args 1]
     set value [lindex $args 2]
+    verbose "dg-set-compiler-env-var $var $value" 2
     if [info exists ::env($var)] {
       lappend saved_compiler_env_var [list $var 1 $::env($var)]
     } else {