| Message ID | c83877dfb8eebb7d52c8da1a6eae80df67d6db0c.1624535812.git.michal.simek@xilinx.com |
|---|---|
| State | Accepted |
| Commit | 5e9d2833ed7973722c5ece0bc07052f5d539c680 |
| Delegated to: | Michal Simek |
| Headers | show |
| Series | serial: Add additional depencies for PL010 and PL011 drivers | expand |
On Thu, 24 Jun 2021 at 05:57, Michal Simek <michal.simek@xilinx.com> wrote: > > Both of these drivers are implemented with and without DM that's why more > symbols should be handled. > The most problematic one is enabling DEBUG_UART_PL011 based on > PL01X_SERIAL(DM based) because debug console has type selection based on > it. > enum pl01x_type type = CONFIG_IS_ENABLED(DEBUG_UART_PL011) ? > TYPE_PL011 : TYPE_PL010; > > Without it pl01x_generic_setbrg() is configuring different registers. > > Fixes: 4cc24aeaf420 ("serial: Add missing Kconfig dependencies for debug consoles") > Signed-off-by: Michal Simek <michal.simek@xilinx.com> > --- > > drivers/serial/Kconfig | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Simon Glass <sjg@chromium.org>
diff --git a/drivers/serial/Kconfig b/drivers/serial/Kconfig index 6d1c4530ddf5..9f82467c4e3c 100644 --- a/drivers/serial/Kconfig +++ b/drivers/serial/Kconfig @@ -332,7 +332,7 @@ config DEBUG_UART_APBUART config DEBUG_UART_PL010 bool "pl010" - depends on PL01X_SERIAL + depends on PL01X_SERIAL || PL010_SERIAL help Select this to enable a debug UART using the pl01x driver with the PL010 UART type. You will need to provide parameters to make this @@ -341,7 +341,7 @@ config DEBUG_UART_PL010 config DEBUG_UART_PL011 bool "pl011" - depends on PL011_SERIAL + depends on PL01X_SERIAL || PL011_SERIAL help Select this to enable a debug UART using the pl01x driver with the PL011 UART type. You will need to provide parameters to make this
Both of these drivers are implemented with and without DM that's why more symbols should be handled. The most problematic one is enabling DEBUG_UART_PL011 based on PL01X_SERIAL(DM based) because debug console has type selection based on it. enum pl01x_type type = CONFIG_IS_ENABLED(DEBUG_UART_PL011) ? TYPE_PL011 : TYPE_PL010; Without it pl01x_generic_setbrg() is configuring different registers. Fixes: 4cc24aeaf420 ("serial: Add missing Kconfig dependencies for debug consoles") Signed-off-by: Michal Simek <michal.simek@xilinx.com> --- drivers/serial/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)