From patchwork Thu Jun 24 11:56:53 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michal Simek X-Patchwork-Id: 1496592 X-Patchwork-Delegate: monstr@monstr.eu Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=monstr-eu.20150623.gappssmtp.com header.i=@monstr-eu.20150623.gappssmtp.com header.a=rsa-sha256 header.s=20150623 header.b=ol62LcJJ; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4G9dsz2Zzbz9sTD for ; Thu, 24 Jun 2021 21:57:25 +1000 (AEST) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id DDA6582B82; Thu, 24 Jun 2021 13:57:14 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=xilinx.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=monstr-eu.20150623.gappssmtp.com header.i=@monstr-eu.20150623.gappssmtp.com header.b="ol62LcJJ"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 218F582B82; Thu, 24 Jun 2021 13:57:12 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.2 Received: from mail-ej1-x629.google.com (mail-ej1-x629.google.com [IPv6:2a00:1450:4864:20::629]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id C465C82B82 for ; Thu, 24 Jun 2021 13:57:07 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=xilinx.com Authentication-Results: phobos.denx.de; spf=none smtp.mailfrom=monstr@monstr.eu Received: by mail-ej1-x629.google.com with SMTP id hq39so9086071ejc.5 for ; Thu, 24 Jun 2021 04:57:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monstr-eu.20150623.gappssmtp.com; s=20150623; h=sender:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=eesMlTDQjqAaoNag4T6EwOIKhzvELG0dbTr9armsAUs=; b=ol62LcJJ9raBsgpC8M0rCZC+Ght8br/OB1Ha4twj0/wdUbflftdULkfZ9y7+KmWgPs ihNjbWgI9xY0UCqcyPAaBKuGQAXPXeZkysEg3bzmsJprusxyBuAZR3a2g1Hcb9ib6UdW cJKy2iyo2oHsRXf7U1sI8zY3mQ8jp9YnMJj4eFg3bb6OgmOek8m4cvGDEfEUVL7A2f+T ib0kdhlUJ44OGFlFoiSV6YC82RnLTlqdbPtef19yYdOQnmIbR5na7GBnzZEtyH8RwFP7 0pMKimB9/QD3oMhQCw9j1G/zt1ISPB8ih2IjEUCHftH/BsBVQfTMHUYTSojqMjWEs/s0 zhSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :mime-version:content-transfer-encoding; bh=eesMlTDQjqAaoNag4T6EwOIKhzvELG0dbTr9armsAUs=; b=VbxeKb51nzTgaNC2Vv+OfT5iIGN+RZAWcuXUTebJvXCWY5hvCQSRNdn4eBaw25K0kL 6NrT7NoE6cqWtBZbZAJ4Mru3/S+b2hwhzzOr1mGZfk4LFUr3A18GILy794zr6xWVvSCu Yij8W9UtaVwRxcMMf6j2rjIfnQ2NNc6RxjzzhN7ZCBBxKrbjjocfSTyD+cV1X3f7ZSbJ s4s/SCfotcsLYtYAmbhzXuOT+f8FAVKl8BHi3bWq1kqP+N9tg6n3hcJEyjyGcSZrpqgP jD4UGj0C+RsjHeSOOPZKpC4LeNRAAshFVmalsMTt22f9UaDRl7MnzIZTBSlhb0J9wqpH 5JPQ== X-Gm-Message-State: AOAM533vhQro3M5ff32OtfPvqOKFjqsK8HYFBCnXchhUEzCTlSW0AfSd 1lvPWg3vsuwaC+mFzYzntyl5deiw67Sk80MR X-Google-Smtp-Source: ABdhPJzdxDX4SV3ZMiaePmKcIGGnN66uFgTbHIf2ywyxxBUsCKNqhpwRBTNztXdJ2qoS8wPSaxD+hA== X-Received: by 2002:a17:906:ce29:: with SMTP id sd9mr5043098ejb.56.1624535827184; Thu, 24 Jun 2021 04:57:07 -0700 (PDT) Received: from localhost ([2a02:768:2307:40d6::648]) by smtp.gmail.com with ESMTPSA id e3sm1144552ejy.78.2021.06.24.04.57.06 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 24 Jun 2021 04:57:06 -0700 (PDT) From: Michal Simek To: u-boot@lists.denx.de, git@xilinx.com Cc: AKASHI Takahiro , Mark Kettenis , Peng Fan , Sean Anderson , Simon Glass , Stefan Roese , Vabhav Sharma , Weijie Gao Subject: [PATCH] serial: Add additional depencies for PL010 and PL011 drivers Date: Thu, 24 Jun 2021 13:56:53 +0200 Message-Id: X-Mailer: git-send-email 2.32.0 MIME-Version: 1.0 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Both of these drivers are implemented with and without DM that's why more symbols should be handled. The most problematic one is enabling DEBUG_UART_PL011 based on PL01X_SERIAL(DM based) because debug console has type selection based on it. enum pl01x_type type = CONFIG_IS_ENABLED(DEBUG_UART_PL011) ? TYPE_PL011 : TYPE_PL010; Without it pl01x_generic_setbrg() is configuring different registers. Fixes: 4cc24aeaf420 ("serial: Add missing Kconfig dependencies for debug consoles") Signed-off-by: Michal Simek Reviewed-by: Simon Glass --- drivers/serial/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/serial/Kconfig b/drivers/serial/Kconfig index 6d1c4530ddf5..9f82467c4e3c 100644 --- a/drivers/serial/Kconfig +++ b/drivers/serial/Kconfig @@ -332,7 +332,7 @@ config DEBUG_UART_APBUART config DEBUG_UART_PL010 bool "pl010" - depends on PL01X_SERIAL + depends on PL01X_SERIAL || PL010_SERIAL help Select this to enable a debug UART using the pl01x driver with the PL010 UART type. You will need to provide parameters to make this @@ -341,7 +341,7 @@ config DEBUG_UART_PL010 config DEBUG_UART_PL011 bool "pl011" - depends on PL011_SERIAL + depends on PL01X_SERIAL || PL011_SERIAL help Select this to enable a debug UART using the pl01x driver with the PL011 UART type. You will need to provide parameters to make this