diff mbox series

[v2,2/2] ARM: dts: imx8m: add UHS or HS400/HS400ES properties

Message ID 20201202180121.11550-1-andrey.zhizhikin@leica-geosystems.com
State Superseded
Delegated to: Stefano Babic
Headers show
Series [v2,1/2] ARM: dts: imx8m: increase off-on delay on the SD Vcc regulator | expand

Commit Message

ZHIZHIKIN Andrey Dec. 2, 2020, 6:01 p.m. UTC
i.MX8M series provide support for high speed grades in their
usdhc controllers, which has eMMC and SDHC connected to them.

Enable this support across the entire i.MX8M family by providing quirks
to usdhc controllers designated by storage media connected to them.

Signed-off-by: Andrey Zhizhikin <andrey.zhizhikin@leica-geosystems.com>
Cc: Stefano Babic <sbabic@denx.de>
Cc: Ye Li <ye.li@nxp.com>
---
Changes in v2: 
- Moved u-boot binding for imx8mq-evk to separate autoincluded dtsi
  files

 arch/arm/dts/fsl-imx8qm-mek-u-boot.dtsi  | 3 +++
 arch/arm/dts/fsl-imx8qxp-mek-u-boot.dtsi | 3 +++
 arch/arm/dts/imx8mm-evk-u-boot.dtsi      | 4 ++++
 arch/arm/dts/imx8mn-ddr4-evk-u-boot.dtsi | 4 ++++
 arch/arm/dts/imx8mp-evk-u-boot.dtsi      | 4 ++++
 arch/arm/dts/imx8mq-evk-u-boot.dtsi      | 9 +++++++++
 6 files changed, 27 insertions(+)

Comments

ZHIZHIKIN Andrey Dec. 4, 2020, 4:49 p.m. UTC | #1
Hello,

I've realized that this patch contains wrong bindings, "u-boot," prefix should be dropped.

Also, configuration values to enable high speed modes in eSDHC are missing from defconfigs - those has to be added as well.

Would sent a V3 for this series, please hold the review of this one.

Sorry for the miss and noise.

> -----Original Message-----
> From: U-Boot <u-boot-bounces@lists.denx.de> On Behalf Of Andrey Zhizhikin
> Sent: Wednesday, December 2, 2020 7:01 PM
> To: u-boot@lists.denx.de
> Cc: Stefano Babic <sbabic@denx.de>; Ye Li <ye.li@nxp.com>
> Subject: [PATCH v2 2/2] ARM: dts: imx8m: add UHS or HS400/HS400ES properties
> 
> This email is not from Hexagon’s Office 365 instance. Please be careful while
> clicking links, opening attachments, or replying to this email.
> 
> 
> i.MX8M series provide support for high speed grades in their usdhc controllers,
> which has eMMC and SDHC connected to them.
> 
> Enable this support across the entire i.MX8M family by providing quirks to usdhc
> controllers designated by storage media connected to them.
> 
> Signed-off-by: Andrey Zhizhikin <andrey.zhizhikin@leica-geosystems.com>
> Cc: Stefano Babic <sbabic@denx.de>
> Cc: Ye Li <ye.li@nxp.com>
> ---
> Changes in v2:
> - Moved u-boot binding for imx8mq-evk to separate autoincluded dtsi
>   files
> 
>  arch/arm/dts/fsl-imx8qm-mek-u-boot.dtsi  | 3 +++  arch/arm/dts/fsl-imx8qxp-
> mek-u-boot.dtsi | 3 +++
>  arch/arm/dts/imx8mm-evk-u-boot.dtsi      | 4 ++++
>  arch/arm/dts/imx8mn-ddr4-evk-u-boot.dtsi | 4 ++++
>  arch/arm/dts/imx8mp-evk-u-boot.dtsi      | 4 ++++
>  arch/arm/dts/imx8mq-evk-u-boot.dtsi      | 9 +++++++++
>  6 files changed, 27 insertions(+)
> 
> diff --git a/arch/arm/dts/fsl-imx8qm-mek-u-boot.dtsi b/arch/arm/dts/fsl-
> imx8qm-mek-u-boot.dtsi
> index 80d6475b7c..2f86fcce3e 100644
> --- a/arch/arm/dts/fsl-imx8qm-mek-u-boot.dtsi
> +++ b/arch/arm/dts/fsl-imx8qm-mek-u-boot.dtsi
> @@ -118,8 +118,11 @@
> 
>  &usdhc1 {
>         u-boot,dm-spl;
> +       u-boot,mmc-hs400-1_8v;
>  };
> 
>  &usdhc2 {
>         u-boot,dm-spl;
> +       u-boot,sd-uhs-sdr104;
> +       u-boot,sd-uhs-ddr50;
>  };
> diff --git a/arch/arm/dts/fsl-imx8qxp-mek-u-boot.dtsi b/arch/arm/dts/fsl-
> imx8qxp-mek-u-boot.dtsi
> index 771ab635f1..f4332edac5 100644
> --- a/arch/arm/dts/fsl-imx8qxp-mek-u-boot.dtsi
> +++ b/arch/arm/dts/fsl-imx8qxp-mek-u-boot.dtsi
> @@ -118,8 +118,11 @@
> 
>  &usdhc1 {
>         u-boot,dm-spl;
> +       u-boot,mmc-hs400-1_8v;
>  };
> 
>  &usdhc2 {
>         u-boot,dm-spl;
> +       u-boot,sd-uhs-sdr104;
> +       u-boot,sd-uhs-ddr50;
>  };
> diff --git a/arch/arm/dts/imx8mm-evk-u-boot.dtsi b/arch/arm/dts/imx8mm-evk-
> u-boot.dtsi
> index 9f77d3c6ff..67666a08ec 100644
> --- a/arch/arm/dts/imx8mm-evk-u-boot.dtsi
> +++ b/arch/arm/dts/imx8mm-evk-u-boot.dtsi
> @@ -100,10 +100,14 @@
> 
>  &usdhc2 {
>         u-boot,dm-spl;
> +       u-boot,sd-uhs-sdr104;
> +       u-boot,sd-uhs-ddr50;
>  };
> 
>  &usdhc3 {
>         u-boot,dm-spl;
> +       u-boot,mmc-hs400-1_8v;
> +       u-boot,mmc-hs400-enhanced-strobe;
>  };
> 
>  &i2c1 {
> diff --git a/arch/arm/dts/imx8mn-ddr4-evk-u-boot.dtsi b/arch/arm/dts/imx8mn-
> ddr4-evk-u-boot.dtsi
> index 98b0b9891b..e03e635213 100644
> --- a/arch/arm/dts/imx8mn-ddr4-evk-u-boot.dtsi
> +++ b/arch/arm/dts/imx8mn-ddr4-evk-u-boot.dtsi
> @@ -97,10 +97,14 @@
> 
>  &usdhc2 {
>         u-boot,dm-spl;
> +       u-boot,sd-uhs-sdr104;
> +       u-boot,sd-uhs-ddr50;
>  };
> 
>  &usdhc3 {
>         u-boot,dm-spl;
> +       u-boot,mmc-hs400-1_8v;
> +       u-boot,mmc-hs400-enhanced-strobe;
>  };
> 
>  &wdog1 {
> diff --git a/arch/arm/dts/imx8mp-evk-u-boot.dtsi b/arch/arm/dts/imx8mp-evk-
> u-boot.dtsi
> index 2452e9175c..0776b24a6e 100644
> --- a/arch/arm/dts/imx8mp-evk-u-boot.dtsi
> +++ b/arch/arm/dts/imx8mp-evk-u-boot.dtsi
> @@ -126,10 +126,14 @@
> 
>  &usdhc2 {
>         u-boot,dm-spl;
> +       u-boot,sd-uhs-sdr104;
> +       u-boot,sd-uhs-ddr50;
>  };
> 
>  &usdhc3 {
>         u-boot,dm-spl;
> +       u-boot,mmc-hs400-1_8v;
> +       u-boot,mmc-hs400-enhanced-strobe;
>  };
> 
>  &wdog1 {
> diff --git a/arch/arm/dts/imx8mq-evk-u-boot.dtsi b/arch/arm/dts/imx8mq-evk-
> u-boot.dtsi
> index 4712cf6a44..d0fc64c433 100644
> --- a/arch/arm/dts/imx8mq-evk-u-boot.dtsi
> +++ b/arch/arm/dts/imx8mq-evk-u-boot.dtsi
> @@ -3,3 +3,12 @@
>  &reg_usdhc2_vmmc {
>         u-boot,off-on-delay-us = <20000>;  };
> +
> +&usdhc1 {
> +       u-boot,mmc-hs400-1_8v;
> +};
> +
> +&usdhc2 {
> +       u-boot,sd-uhs-sdr104;
> +       u-boot,sd-uhs-ddr50;
> +};
> --
> 2.17.1

-- andrey
diff mbox series

Patch

diff --git a/arch/arm/dts/fsl-imx8qm-mek-u-boot.dtsi b/arch/arm/dts/fsl-imx8qm-mek-u-boot.dtsi
index 80d6475b7c..2f86fcce3e 100644
--- a/arch/arm/dts/fsl-imx8qm-mek-u-boot.dtsi
+++ b/arch/arm/dts/fsl-imx8qm-mek-u-boot.dtsi
@@ -118,8 +118,11 @@ 
 
 &usdhc1 {
 	u-boot,dm-spl;
+	u-boot,mmc-hs400-1_8v;
 };
 
 &usdhc2 {
 	u-boot,dm-spl;
+	u-boot,sd-uhs-sdr104;
+	u-boot,sd-uhs-ddr50;
 };
diff --git a/arch/arm/dts/fsl-imx8qxp-mek-u-boot.dtsi b/arch/arm/dts/fsl-imx8qxp-mek-u-boot.dtsi
index 771ab635f1..f4332edac5 100644
--- a/arch/arm/dts/fsl-imx8qxp-mek-u-boot.dtsi
+++ b/arch/arm/dts/fsl-imx8qxp-mek-u-boot.dtsi
@@ -118,8 +118,11 @@ 
 
 &usdhc1 {
 	u-boot,dm-spl;
+	u-boot,mmc-hs400-1_8v;
 };
 
 &usdhc2 {
 	u-boot,dm-spl;
+	u-boot,sd-uhs-sdr104;
+	u-boot,sd-uhs-ddr50;
 };
diff --git a/arch/arm/dts/imx8mm-evk-u-boot.dtsi b/arch/arm/dts/imx8mm-evk-u-boot.dtsi
index 9f77d3c6ff..67666a08ec 100644
--- a/arch/arm/dts/imx8mm-evk-u-boot.dtsi
+++ b/arch/arm/dts/imx8mm-evk-u-boot.dtsi
@@ -100,10 +100,14 @@ 
 
 &usdhc2 {
 	u-boot,dm-spl;
+	u-boot,sd-uhs-sdr104;
+	u-boot,sd-uhs-ddr50;
 };
 
 &usdhc3 {
 	u-boot,dm-spl;
+	u-boot,mmc-hs400-1_8v;
+	u-boot,mmc-hs400-enhanced-strobe;
 };
 
 &i2c1 {
diff --git a/arch/arm/dts/imx8mn-ddr4-evk-u-boot.dtsi b/arch/arm/dts/imx8mn-ddr4-evk-u-boot.dtsi
index 98b0b9891b..e03e635213 100644
--- a/arch/arm/dts/imx8mn-ddr4-evk-u-boot.dtsi
+++ b/arch/arm/dts/imx8mn-ddr4-evk-u-boot.dtsi
@@ -97,10 +97,14 @@ 
 
 &usdhc2 {
 	u-boot,dm-spl;
+	u-boot,sd-uhs-sdr104;
+	u-boot,sd-uhs-ddr50;
 };
 
 &usdhc3 {
 	u-boot,dm-spl;
+	u-boot,mmc-hs400-1_8v;
+	u-boot,mmc-hs400-enhanced-strobe;
 };
 
 &wdog1 {
diff --git a/arch/arm/dts/imx8mp-evk-u-boot.dtsi b/arch/arm/dts/imx8mp-evk-u-boot.dtsi
index 2452e9175c..0776b24a6e 100644
--- a/arch/arm/dts/imx8mp-evk-u-boot.dtsi
+++ b/arch/arm/dts/imx8mp-evk-u-boot.dtsi
@@ -126,10 +126,14 @@ 
 
 &usdhc2 {
 	u-boot,dm-spl;
+	u-boot,sd-uhs-sdr104;
+	u-boot,sd-uhs-ddr50;
 };
 
 &usdhc3 {
 	u-boot,dm-spl;
+	u-boot,mmc-hs400-1_8v;
+	u-boot,mmc-hs400-enhanced-strobe;
 };
 
 &wdog1 {
diff --git a/arch/arm/dts/imx8mq-evk-u-boot.dtsi b/arch/arm/dts/imx8mq-evk-u-boot.dtsi
index 4712cf6a44..d0fc64c433 100644
--- a/arch/arm/dts/imx8mq-evk-u-boot.dtsi
+++ b/arch/arm/dts/imx8mq-evk-u-boot.dtsi
@@ -3,3 +3,12 @@ 
 &reg_usdhc2_vmmc {
 	u-boot,off-on-delay-us = <20000>;
 };
+
+&usdhc1 {
+	u-boot,mmc-hs400-1_8v;
+};
+
+&usdhc2 {
+	u-boot,sd-uhs-sdr104;
+	u-boot,sd-uhs-ddr50;
+};