diff mbox series

[RFC,WIP,v1,7/7] wandboard: in SPL use only D1 DTB

Message ID 20200114061314.148491-8-hs@denx.de
State RFC
Delegated to: Stefano Babic
Headers show
Series wandboard: add imx6dl rev d1 support | expand

Commit Message

Heiko Schocher Jan. 14, 2020, 6:13 a.m. UTC 
Signed-off-by: Heiko Schocher <hs@denx.de>
---

 board/wandboard/wandboard.c | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Fabio Estevam Jan. 15, 2020, 7:54 p.m. UTC | #1 
Hi Heiko,

On Tue, Jan 14, 2020 at 3:14 AM Heiko Schocher <hs@denx.de> wrote:

> +#if defined(CONFIG_SPL_BUILD)
> +       /* in SPL we use only revision D1 DTB */
> +       if (1) {
> +#else
>         if (is_revd1()) {
> +#endif

Is there a way to improve is_revd1() so that it can call i2c_probe()
and detect whether the PMIC is present or not?

Thanks
Heiko Schocher Jan. 16, 2020, 6:20 a.m. UTC | #2 
Hello Fabio,

Am 15.01.2020 um 20:54 schrieb Fabio Estevam:
> Hi Heiko,
> 
> On Tue, Jan 14, 2020 at 3:14 AM Heiko Schocher <hs@denx.de> wrote:
> 
>> +#if defined(CONFIG_SPL_BUILD)
>> +       /* in SPL we use only revision D1 DTB */
>> +       if (1) {
>> +#else
>>          if (is_revd1()) {
>> +#endif
> 
> Is there a way to improve is_revd1() so that it can call i2c_probe()
> and detect whether the PMIC is present or not?

It is WIP so maybe yes ;-)

bye,
Heiko
diff mbox series

Patch

diff --git a/board/wandboard/wandboard.c b/board/wandboard/wandboard.c
index ae4ad765a83..6b7210c0992 100644
--- a/board/wandboard/wandboard.c
+++ b/board/wandboard/wandboard.c
@@ -489,7 +489,12 @@  int board_fit_config_name_match(const char *name)
 			return 0;
 	}
 
+#if defined(CONFIG_SPL_BUILD)
+	/* in SPL we use only revision D1 DTB */
+	if (1) {
+#else
 	if (is_revd1()) {
+#endif
 		if (is_mx6dq()) {
 			if (!strcmp(name, "imx6q-wandboard-revd1"))
 				return 0;