| Message ID | 20200114061314.148491-7-hs@denx.de |
|---|---|
| State | RFC |
| Delegated to: | Stefano Babic |
| Headers | show |
| Series | wandboard: add imx6dl rev d1 support | expand |
Hi Heiko, On Tue, Jan 14, 2020 at 3:14 AM Heiko Schocher <hs@denx.de> wrote: > > we want to access PMIC before relocation, so we need > to add u-boot specific "u-boot,dm-pre-reloc" properties. > > Signed-off-by: Heiko Schocher <hs@denx.de> > --- > > arch/arm/dts/imx6dl-wandboard-revd1-u-boot.dtsi | 11 +++++++++++ > arch/arm/dts/imx6q-wandboard-revd1-u-boot.dtsi | 11 +++++++++++ > 2 files changed, 22 insertions(+) > create mode 100644 arch/arm/dts/imx6dl-wandboard-revd1-u-boot.dtsi > create mode 100644 arch/arm/dts/imx6q-wandboard-revd1-u-boot.dtsi The imx6q-wandboard-revd1-u-boot.dtsi is missing. Thanks
Hello Fabio, Am 15.01.2020 um 20:52 schrieb Fabio Estevam: > Hi Heiko, > > On Tue, Jan 14, 2020 at 3:14 AM Heiko Schocher <hs@denx.de> wrote: >> >> we want to access PMIC before relocation, so we need >> to add u-boot specific "u-boot,dm-pre-reloc" properties. >> >> Signed-off-by: Heiko Schocher <hs@denx.de> >> --- >> >> arch/arm/dts/imx6dl-wandboard-revd1-u-boot.dtsi | 11 +++++++++++ >> arch/arm/dts/imx6q-wandboard-revd1-u-boot.dtsi | 11 +++++++++++ >> 2 files changed, 22 insertions(+) >> create mode 100644 arch/arm/dts/imx6dl-wandboard-revd1-u-boot.dtsi >> create mode 100644 arch/arm/dts/imx6q-wandboard-revd1-u-boot.dtsi > > The imx6q-wandboard-revd1-u-boot.dtsi is missing. Ah, ok, I can add it ... wait for your testing results. bye, Heiko
Hi Heiko,
On Thu, Jan 16, 2020 at 3:18 AM Heiko Schocher <hs@denx.de> wrote:
> Ah, ok, I can add it ... wait for your testing results.
I haven't had a chance to test this series, sorry, but after thinking
more about it I would prefer to test an improved version of this
series because:
1. is_revd1() needs to be done in SPL (if we manage to fix this, it
seems we would not need some of the patches of this current series)
2. This series still causes issues on your board: "On hardreset, the
PMIC does not respond
on i2c bus"
Thanks
diff --git a/arch/arm/dts/imx6dl-wandboard-revd1-u-boot.dtsi b/arch/arm/dts/imx6dl-wandboard-revd1-u-boot.dtsi new file mode 100644 index 00000000000..93e88fa1148 --- /dev/null +++ b/arch/arm/dts/imx6dl-wandboard-revd1-u-boot.dtsi @@ -0,0 +1,11 @@ +// SPDX-License-Identifier: GPL-2.0 +// +// Copyright (C) 2020 Heiko Schocher <hs@denx.de> + +&i2c3 { + u-boot,dm-pre-reloc; +}; + +&pmic { + u-boot,dm-pre-reloc; +}; diff --git a/arch/arm/dts/imx6q-wandboard-revd1-u-boot.dtsi b/arch/arm/dts/imx6q-wandboard-revd1-u-boot.dtsi new file mode 100644 index 00000000000..93e88fa1148 --- /dev/null +++ b/arch/arm/dts/imx6q-wandboard-revd1-u-boot.dtsi @@ -0,0 +1,11 @@ +// SPDX-License-Identifier: GPL-2.0 +// +// Copyright (C) 2020 Heiko Schocher <hs@denx.de> + +&i2c3 { + u-boot,dm-pre-reloc; +}; + +&pmic { + u-boot,dm-pre-reloc; +};
we want to access PMIC before relocation, so we need to add u-boot specific "u-boot,dm-pre-reloc" properties. Signed-off-by: Heiko Schocher <hs@denx.de> --- arch/arm/dts/imx6dl-wandboard-revd1-u-boot.dtsi | 11 +++++++++++ arch/arm/dts/imx6q-wandboard-revd1-u-boot.dtsi | 11 +++++++++++ 2 files changed, 22 insertions(+) create mode 100644 arch/arm/dts/imx6dl-wandboard-revd1-u-boot.dtsi create mode 100644 arch/arm/dts/imx6q-wandboard-revd1-u-boot.dtsi