diff mbox series

[v2,15/30] ctype: Avoid using a symlink

Message ID 20230430013003.1047454-16-sjg@chromium.org
State Changes Requested
Delegated to: Tom Rini
Headers show
Series Allow building sandbox with MSYS2 | expand

Commit Message

Simon Glass April 30, 2023, 1:29 a.m. UTC
Windows doesn't really support symlinks so fails to build this file. Use
a single-line #include instead.

Signed-off-by: Simon Glass <sjg@chromium.org>
---

(no changes since v1)

 include/ctype.h | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)
 mode change 120000 => 100644 include/ctype.h

Comments

Bin Meng May 1, 2023, 9:03 a.m. UTC | #1
Hi Simon,

On Sun, Apr 30, 2023 at 9:30 AM Simon Glass <sjg@chromium.org> wrote:
>
> Windows doesn't really support symlinks so fails to build this file. Use
> a single-line #include instead.
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
> ---
>
> (no changes since v1)
>
>  include/ctype.h | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
>  mode change 120000 => 100644 include/ctype.h
>

This patch does not seem necessary if:

1. Enable Windows developer mode
2. export MSYS=winsymlinks:native

Regards,
Bin
diff mbox series

Patch

diff --git a/include/ctype.h b/include/ctype.h
deleted file mode 120000
index 9e43f9c6c6c4..000000000000
--- a/include/ctype.h
+++ /dev/null
@@ -1 +0,0 @@ 
-linux/ctype.h
\ No newline at end of file
diff --git a/include/ctype.h b/include/ctype.h
new file mode 100644
index 000000000000..155e3c63e59d
--- /dev/null
+++ b/include/ctype.h
@@ -0,0 +1,6 @@ 
+/* SPDX-License-Identifier: GPL-2.0+ */
+/*
+ * Copyright 2023 Google LLC
+ */
+
+#include <linux/ctype.h>