| Message ID | 20210625130547.2177920-7-maxime@cerno.tech |
|---|---|
| State | RFC |
| Delegated to: | Andre Przywara |
| Headers | show |
| Series | Random Fixes for the CHIP Pro | expand |
On Fri, 25 Jun 2021 15:05:41 +0200 Maxime Ripard <maxime@cerno.tech> wrote: > Most of the error messages in the NAND fastboot support are missing a \n > at the end, add it where relevant. > > Signed-off-by: Maxime Ripard <maxime@cerno.tech> Reviewed-by: Andre Przywara <andre.przywara@arm.com> Thanks! Andre > --- > drivers/fastboot/fb_nand.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/fastboot/fb_nand.c b/drivers/fastboot/fb_nand.c > index eb8a36f29222..e07df33d3665 100644 > --- a/drivers/fastboot/fb_nand.c > +++ b/drivers/fastboot/fb_nand.c > @@ -49,13 +49,13 @@ static int fb_nand_lookup(const char *partname, > > ret = find_dev_and_part(partname, &dev, &pnum, part); > if (ret) { > - pr_err("cannot find partition: '%s'", partname); > + pr_err("cannot find partition: '%s'\n", partname); > fastboot_fail("cannot find partition", response); > return ret; > } > > if (dev->id->type != MTD_DEV_TYPE_NAND) { > - pr_err("partition '%s' is not stored on a NAND device", > + pr_err("partition '%s' is not stored on a NAND device\n", > partname); > fastboot_fail("not a NAND device", response); > return -EINVAL; > @@ -179,7 +179,7 @@ void fastboot_nand_flash_write(const char *cmd, void *download_buffer, > > ret = fb_nand_lookup(cmd, &mtd, &part, response); > if (ret) { > - pr_err("invalid NAND device"); > + pr_err("invalid NAND device\n"); > fastboot_fail("invalid NAND device", response); > return; > } > @@ -243,7 +243,7 @@ void fastboot_nand_erase(const char *cmd, char *response) > > ret = fb_nand_lookup(cmd, &mtd, &part, response); > if (ret) { > - pr_err("invalid NAND device"); > + pr_err("invalid NAND device\n"); > fastboot_fail("invalid NAND device", response); > return; > } > @@ -254,7 +254,7 @@ void fastboot_nand_erase(const char *cmd, char *response) > > ret = _fb_nand_erase(mtd, part); > if (ret) { > - pr_err("failed erasing from device %s", mtd->name); > + pr_err("failed erasing from device %s\n", mtd->name); > fastboot_fail("failed erasing from device", response); > return; > }
diff --git a/drivers/fastboot/fb_nand.c b/drivers/fastboot/fb_nand.c index eb8a36f29222..e07df33d3665 100644 --- a/drivers/fastboot/fb_nand.c +++ b/drivers/fastboot/fb_nand.c @@ -49,13 +49,13 @@ static int fb_nand_lookup(const char *partname, ret = find_dev_and_part(partname, &dev, &pnum, part); if (ret) { - pr_err("cannot find partition: '%s'", partname); + pr_err("cannot find partition: '%s'\n", partname); fastboot_fail("cannot find partition", response); return ret; } if (dev->id->type != MTD_DEV_TYPE_NAND) { - pr_err("partition '%s' is not stored on a NAND device", + pr_err("partition '%s' is not stored on a NAND device\n", partname); fastboot_fail("not a NAND device", response); return -EINVAL; @@ -179,7 +179,7 @@ void fastboot_nand_flash_write(const char *cmd, void *download_buffer, ret = fb_nand_lookup(cmd, &mtd, &part, response); if (ret) { - pr_err("invalid NAND device"); + pr_err("invalid NAND device\n"); fastboot_fail("invalid NAND device", response); return; } @@ -243,7 +243,7 @@ void fastboot_nand_erase(const char *cmd, char *response) ret = fb_nand_lookup(cmd, &mtd, &part, response); if (ret) { - pr_err("invalid NAND device"); + pr_err("invalid NAND device\n"); fastboot_fail("invalid NAND device", response); return; } @@ -254,7 +254,7 @@ void fastboot_nand_erase(const char *cmd, char *response) ret = _fb_nand_erase(mtd, part); if (ret) { - pr_err("failed erasing from device %s", mtd->name); + pr_err("failed erasing from device %s\n", mtd->name); fastboot_fail("failed erasing from device", response); return; }
Most of the error messages in the NAND fastboot support are missing a \n at the end, add it where relevant. Signed-off-by: Maxime Ripard <maxime@cerno.tech> --- drivers/fastboot/fb_nand.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)