From patchwork Fri Jun 25 13:05:41 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Maxime Ripard X-Patchwork-Id: 1497271 X-Patchwork-Delegate: andre.przywara@arm.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=cerno.tech header.i=@cerno.tech header.a=rsa-sha256 header.s=fm3 header.b=VhtUigzb; dkim=pass (2048-bit key; unprotected) header.d=messagingengine.com header.i=@messagingengine.com header.a=rsa-sha256 header.s=fm3 header.b=jf8gVVps; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4GBHN542g8z9sV8 for ; Fri, 25 Jun 2021 23:07:17 +1000 (AEST) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 7C6BE82C12; Fri, 25 Jun 2021 15:06:35 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=cerno.tech Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=cerno.tech header.i=@cerno.tech header.b="VhtUigzb"; dkim=pass (2048-bit key; unprotected) header.d=messagingengine.com header.i=@messagingengine.com header.b="jf8gVVps"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 6487182C1F; Fri, 25 Jun 2021 15:06:09 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL, SPF_HELO_PASS autolearn=ham autolearn_force=no version=3.4.2 Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 0884682C0D for ; Fri, 25 Jun 2021 15:06:03 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=cerno.tech Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=maxime@cerno.tech Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 472395C00FB; Fri, 25 Jun 2021 09:06:02 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Fri, 25 Jun 2021 09:06:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; s=fm3; bh=5bPIagSpe9uFW hX5/IbMdG5+cdLBR61vL+6J5RjHAGM=; b=VhtUigzbZMGpwOexUKZ/1H8FuSDlI kdVVGQJQpbxYxIlrLVuZPn5R1/VzmFXv1yi1uiioh2sZscUAzedeJAnfYysi/UX/ kGAfsC0Fl67vFtDbdMVwnmzEr2G8/4rJ6hnQ4q0N6wVbNBtKzMqUu3W/snscIMlh 40/dyr73INSIQ33ds0NET5iHKx8GrEezICz2q1rOltqLrQgHfC7pVyeQP6w+b3x/ r2HJEyBttgZryzOWWU7d8qVm+out7xIWLKTKopEpYmkB9xjMNnVEPx71Zlq+JMzz 7QzGs8JWvDeQxWklobkoPaH+3yUuQYwv72/ikju76bFs9qgUnA3AefDfw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:date:from :in-reply-to:message-id:mime-version:references:subject:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; bh=5bPIagSpe9uFWhX5/IbMdG5+cdLBR61vL+6J5RjHAGM=; b=jf8gVVps wQrVmXAu/1bylgXGFpVhMoVJOO7kXD5Tmdxng5zIJoxkRnR2NqWMcdvVjdQLgszM s/ieOfZP8REXAqNSnALqnTtiSf6yoQfLsE/meWpjgLH6oN+BHgEdN0jrnJjAF24G il4WO+SOTlR7IgORMs0uXEqDeI2dZKoOCMSn+0CbnbL5So8qzkDjADKpMHq6GZJx O/qWZg/Ic9iTcBb64vrXWP5XeYKrliVlQj3fMjK/SQjpVjUr9m9sw18ADUgUPr0L V8z3x4+pEiFocI6/qonY+SwcH+Ia9b7tiKy1J//TsWea3U8Ft5RAz1m2WzLCEHAI D+RPDC4Uohf5lg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrfeegjedgheeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkffojghfggfgsedtkeertdertddtnecuhfhrohhmpeforgigihhm vgcutfhiphgrrhguuceomhgrgihimhgvsegtvghrnhhordhtvggthheqnecuggftrfgrth htvghrnhepvdekleevfeffkeejhfffueelteelfeduieefheduudfggffhhfffheevveeh hedvnecuvehluhhsthgvrhfuihiivgepudenucfrrghrrghmpehmrghilhhfrhhomhepmh grgihimhgvsegtvghrnhhordhtvggthh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 25 Jun 2021 09:06:01 -0400 (EDT) From: Maxime Ripard To: u-boot@lists.denx.de, Andre Przywara Cc: Peng Fan , Li Jun , Marek Vasut , Tom Rini , Miquel Raynal , Jagan Teki , Maxime Ripard Subject: [PATCH 06/12] fastboot: Add missing newlines Date: Fri, 25 Jun 2021 15:05:41 +0200 Message-Id: <20210625130547.2177920-7-maxime@cerno.tech> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210625130547.2177920-1-maxime@cerno.tech> References: <20210625130547.2177920-1-maxime@cerno.tech> MIME-Version: 1.0 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Most of the error messages in the NAND fastboot support are missing a \n at the end, add it where relevant. Signed-off-by: Maxime Ripard Reviewed-by: Andre Przywara --- drivers/fastboot/fb_nand.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/fastboot/fb_nand.c b/drivers/fastboot/fb_nand.c index eb8a36f29222..e07df33d3665 100644 --- a/drivers/fastboot/fb_nand.c +++ b/drivers/fastboot/fb_nand.c @@ -49,13 +49,13 @@ static int fb_nand_lookup(const char *partname, ret = find_dev_and_part(partname, &dev, &pnum, part); if (ret) { - pr_err("cannot find partition: '%s'", partname); + pr_err("cannot find partition: '%s'\n", partname); fastboot_fail("cannot find partition", response); return ret; } if (dev->id->type != MTD_DEV_TYPE_NAND) { - pr_err("partition '%s' is not stored on a NAND device", + pr_err("partition '%s' is not stored on a NAND device\n", partname); fastboot_fail("not a NAND device", response); return -EINVAL; @@ -179,7 +179,7 @@ void fastboot_nand_flash_write(const char *cmd, void *download_buffer, ret = fb_nand_lookup(cmd, &mtd, &part, response); if (ret) { - pr_err("invalid NAND device"); + pr_err("invalid NAND device\n"); fastboot_fail("invalid NAND device", response); return; } @@ -243,7 +243,7 @@ void fastboot_nand_erase(const char *cmd, char *response) ret = fb_nand_lookup(cmd, &mtd, &part, response); if (ret) { - pr_err("invalid NAND device"); + pr_err("invalid NAND device\n"); fastboot_fail("invalid NAND device", response); return; } @@ -254,7 +254,7 @@ void fastboot_nand_erase(const char *cmd, char *response) ret = _fb_nand_erase(mtd, part); if (ret) { - pr_err("failed erasing from device %s", mtd->name); + pr_err("failed erasing from device %s\n", mtd->name); fastboot_fail("failed erasing from device", response); return; }