[11/20] net: phy: fixed: Make driver ops static

Message ID	20210302153451.19440-12-bmeng.cn@gmail.com
State	Superseded
Delegated to:	Priyanka Jain
Headers	show Return-Path: <u-boot-bounces@lists.denx.de> From: Bin Meng <bmeng.cn@gmail.com> To: Priyanka Jain <priyanka.jain@nxp.com>, Simon Glass <sjg@chromium.org>, u-boot@lists.denx.de Cc: Tom Rini <trini@konsulko.com>, Alexander Graf <agraf@csgraf.de>, Bin Meng <bmeng.cn@gmail.com>, Claudiu Manoil <claudiu.manoil@nxp.com>, Joe Hershberger <joe.hershberger@ni.com>, Ramon Fried <rfried.dev@gmail.com>, Vladimir Oltean <vladimir.oltean@nxp.com> Subject: [PATCH 11/20] net: phy: fixed: Make driver ops static Date: Tue, 2 Mar 2021 23:34:42 +0800 Message-Id: <20210302153451.19440-12-bmeng.cn@gmail.com> In-Reply-To: <20210302153451.19440-1-bmeng.cn@gmail.com> References: <20210302153451.19440-1-bmeng.cn@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: list Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" <u-boot-bounces@lists.denx.de>
Series	ppc: qemu: Add eTSEC support \| expand [00/20] ppc: qemu: Add eTSEC support [01/20] net: phy: xilinx: Remove non-DM prototype of phy_connect_gmii2rgmii() [02/20] net: phy: xilinx: Convert to use APIs which support live DT [03/20] net: phy: fixed: Remove non-DM prototype of phy_connect_fixed() [04/20] net: phy: fixed: Convert to use APIs which support live DT [05/20] dt-bindings: net: Add the old DT bindings for "fixed-link" [06/20] of: extra: Introduce ofnode_phy_is_fixed_link() API [07/20] test: dm: Add a case to test ofnode_phy_is_fixed_link() [08/20] dm: mdio: Use ofnode_phy_is_fixed_link() API [09/20] net: tsec: Use ofnode_phy_is_fixed_link() API [10/20] net: phy: Simplify the logic of phy_connect_fixed() [11/20] net: phy: fixed: Make driver ops static [12/20] net: phy: fixed: Add the missing ending newline [13/20] net: phy: fixed: Support the old DT binding [14/20] dt-bindings: net: Update Freescale TSEC to support "queue-group" [15/20] net: tsec: Support <reg> property from the subnode "queue-group" [16/20] dm: core: Correctly read <ranges> of simple-bus [17/20] test: dm: Add a test case for simple-bus <ranges> [18/20] ppc: qemu: Create a virtual memory mapping of the platform bus [19/20] ppc: qemu: Enable eTSEC support [20/20] doc: board: qemu-ppce500: Document eTSEC usage

Message ID

20210302153451.19440-12-bmeng.cn@gmail.com

State

Superseded

Delegated to:

Priyanka Jain

Headers

From: Bin Meng <bmeng.cn@gmail.com>
To: Priyanka Jain <priyanka.jain@nxp.com>, Simon Glass <sjg@chromium.org>,
 u-boot@lists.denx.de
Cc: Tom Rini <trini@konsulko.com>, Alexander Graf <agraf@csgraf.de>,
 Bin Meng <bmeng.cn@gmail.com>, Claudiu Manoil <claudiu.manoil@nxp.com>,
 Joe Hershberger <joe.hershberger@ni.com>,
 Ramon Fried <rfried.dev@gmail.com>,
 Vladimir Oltean <vladimir.oltean@nxp.com>
Subject: [PATCH 11/20] net: phy: fixed: Make driver ops static
Date: Tue,  2 Mar 2021 23:34:42 +0800
Message-Id: <20210302153451.19440-12-bmeng.cn@gmail.com>
In-Reply-To: <20210302153451.19440-1-bmeng.cn@gmail.com>
References: <20210302153451.19440-1-bmeng.cn@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: list
Errors-To: u-boot-bounces@lists.denx.de
Sender: "U-Boot" <u-boot-bounces@lists.denx.de>

Series

ppc: qemu: Add eTSEC support | expand

Comments

Ramon Fried March 2, 2021, 5:47 p.m. UTC | #1

On Tue, Mar 2, 2021 at 5:36 PM Bin Meng <bmeng.cn@gmail.com> wrote:
>
> The PHY driver ops should be made static.
>
> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
> ---
>
>  drivers/net/phy/fixed.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/phy/fixed.c b/drivers/net/phy/fixed.c
> index 1a38c29469..2a41baf8d7 100644
> --- a/drivers/net/phy/fixed.c
> +++ b/drivers/net/phy/fixed.c
> @@ -15,7 +15,7 @@
>
>  DECLARE_GLOBAL_DATA_PTR;
>
> -int fixedphy_probe(struct phy_device *phydev)
> +static int fixedphy_probe(struct phy_device *phydev)
>  {
>         struct fixed_link *priv;
>         int ofnode = phydev->addr;
> @@ -48,7 +48,7 @@ int fixedphy_probe(struct phy_device *phydev)
>         return 0;
>  }
>
> -int fixedphy_startup(struct phy_device *phydev)
> +static int fixedphy_startup(struct phy_device *phydev)
>  {
>         struct fixed_link *priv = phydev->priv;
>
> @@ -61,7 +61,7 @@ int fixedphy_startup(struct phy_device *phydev)
>         return 0;
>  }
>
> -int fixedphy_shutdown(struct phy_device *phydev)
> +static int fixedphy_shutdown(struct phy_device *phydev)
>  {
>         return 0;
>  }
> --
> 2.25.1
>
Reviewed-By: Ramon Fried <rfried.dev@gmail.com>

diff --git a/drivers/net/phy/fixed.c b/drivers/net/phy/fixed.c
index 1a38c29469..2a41baf8d7 100644
--- a/drivers/net/phy/fixed.c
+++ b/drivers/net/phy/fixed.c
@@ -15,7 +15,7 @@ 
 
 DECLARE_GLOBAL_DATA_PTR;
 
-int fixedphy_probe(struct phy_device *phydev)
+static int fixedphy_probe(struct phy_device *phydev)
 {
 	struct fixed_link *priv;
 	int ofnode = phydev->addr;
@@ -48,7 +48,7 @@  int fixedphy_probe(struct phy_device *phydev)
 	return 0;
 }
 
-int fixedphy_startup(struct phy_device *phydev)
+static int fixedphy_startup(struct phy_device *phydev)
 {
 	struct fixed_link *priv = phydev->priv;
 
@@ -61,7 +61,7 @@  int fixedphy_startup(struct phy_device *phydev)
 	return 0;
 }
 
-int fixedphy_shutdown(struct phy_device *phydev)
+static int fixedphy_shutdown(struct phy_device *phydev)
 {
 	return 0;
 }

[11/20] net: phy: fixed: Make driver ops static

Commit Message

Comments

Patch