[09/20] net: tsec: Use ofnode_phy_is_fixed_link() API

Message ID	20210302153451.19440-10-bmeng.cn@gmail.com
State	Superseded
Delegated to:	Priyanka Jain
Headers	show Return-Path: <u-boot-bounces@lists.denx.de> From: Bin Meng <bmeng.cn@gmail.com> To: Priyanka Jain <priyanka.jain@nxp.com>, Simon Glass <sjg@chromium.org>, u-boot@lists.denx.de Cc: Tom Rini <trini@konsulko.com>, Alexander Graf <agraf@csgraf.de>, Bin Meng <bmeng.cn@gmail.com>, Joe Hershberger <joe.hershberger@ni.com>, Ramon Fried <rfried.dev@gmail.com> Subject: [PATCH 09/20] net: tsec: Use ofnode_phy_is_fixed_link() API Date: Tue, 2 Mar 2021 23:34:40 +0800 Message-Id: <20210302153451.19440-10-bmeng.cn@gmail.com> In-Reply-To: <20210302153451.19440-1-bmeng.cn@gmail.com> References: <20210302153451.19440-1-bmeng.cn@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: list Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" <u-boot-bounces@lists.denx.de>
Series	ppc: qemu: Add eTSEC support \| expand [00/20] ppc: qemu: Add eTSEC support [01/20] net: phy: xilinx: Remove non-DM prototype of phy_connect_gmii2rgmii() [02/20] net: phy: xilinx: Convert to use APIs which support live DT [03/20] net: phy: fixed: Remove non-DM prototype of phy_connect_fixed() [04/20] net: phy: fixed: Convert to use APIs which support live DT [05/20] dt-bindings: net: Add the old DT bindings for "fixed-link" [06/20] of: extra: Introduce ofnode_phy_is_fixed_link() API [07/20] test: dm: Add a case to test ofnode_phy_is_fixed_link() [08/20] dm: mdio: Use ofnode_phy_is_fixed_link() API [09/20] net: tsec: Use ofnode_phy_is_fixed_link() API [10/20] net: phy: Simplify the logic of phy_connect_fixed() [11/20] net: phy: fixed: Make driver ops static [12/20] net: phy: fixed: Add the missing ending newline [13/20] net: phy: fixed: Support the old DT binding [14/20] dt-bindings: net: Update Freescale TSEC to support "queue-group" [15/20] net: tsec: Support <reg> property from the subnode "queue-group" [16/20] dm: core: Correctly read <ranges> of simple-bus [17/20] test: dm: Add a test case for simple-bus <ranges> [18/20] ppc: qemu: Create a virtual memory mapping of the platform bus [19/20] ppc: qemu: Enable eTSEC support [20/20] doc: board: qemu-ppce500: Document eTSEC usage

Message ID

20210302153451.19440-10-bmeng.cn@gmail.com

State

Superseded

Delegated to:

Priyanka Jain

Headers

From: Bin Meng <bmeng.cn@gmail.com>
To: Priyanka Jain <priyanka.jain@nxp.com>, Simon Glass <sjg@chromium.org>,
 u-boot@lists.denx.de
Cc: Tom Rini <trini@konsulko.com>, Alexander Graf <agraf@csgraf.de>,
 Bin Meng <bmeng.cn@gmail.com>, Joe Hershberger <joe.hershberger@ni.com>,
 Ramon Fried <rfried.dev@gmail.com>
Subject: [PATCH 09/20] net: tsec: Use ofnode_phy_is_fixed_link() API
Date: Tue,  2 Mar 2021 23:34:40 +0800
Message-Id: <20210302153451.19440-10-bmeng.cn@gmail.com>
In-Reply-To: <20210302153451.19440-1-bmeng.cn@gmail.com>
References: <20210302153451.19440-1-bmeng.cn@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: list
Errors-To: u-boot-bounces@lists.denx.de
Sender: "U-Boot" <u-boot-bounces@lists.denx.de>

Series

ppc: qemu: Add eTSEC support | expand

Switch to use the ofnode_phy_is_fixed_link() API which can support both the new and old DT bindings. Signed-off-by: Bin Meng <bmeng.cn@gmail.com> --- drivers/net/tsec.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Ramon Fried March 2, 2021, 5:42 p.m. UTC | #1

On Tue, Mar 2, 2021 at 5:35 PM Bin Meng <bmeng.cn@gmail.com> wrote:
>
> Switch to use the ofnode_phy_is_fixed_link() API which can support
> both the new and old DT bindings.
>
> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
> ---
>
>  drivers/net/tsec.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/tsec.c b/drivers/net/tsec.c
> index ec48689372..24f9962b82 100644
> --- a/drivers/net/tsec.c
> +++ b/drivers/net/tsec.c
> @@ -15,6 +15,7 @@
>  #include <command.h>
>  #include <tsec.h>
>  #include <fsl_mdio.h>
> +#include <dm/of_extra.h>
>  #include <linux/bitops.h>
>  #include <linux/delay.h>
>  #include <linux/errno.h>
> @@ -707,8 +708,7 @@ static int init_phy(struct tsec_private *priv)
>                 tsec_configure_serdes(priv);
>
>  #if defined(CONFIG_DM_ETH) && defined(CONFIG_DM_MDIO)
> -       if (ofnode_valid(ofnode_find_subnode(dev_ofnode(priv->dev),
> -                                            "fixed-link")))
> +       if (ofnode_phy_is_fixed_link(dev_ofnode(priv->dev), NULL))
>                 phydev = phy_connect(NULL, 0, priv->dev, priv->interface);
>         else
>                 phydev = dm_eth_phy_connect(priv->dev);
> --
> 2.25.1
>
Reviewed-By: Ramon Fried <rfried.dev@gmail.com>

diff --git a/drivers/net/tsec.c b/drivers/net/tsec.c
index ec48689372..24f9962b82 100644
--- a/drivers/net/tsec.c
+++ b/drivers/net/tsec.c
@@ -15,6 +15,7 @@ 
 #include <command.h>
 #include <tsec.h>
 #include <fsl_mdio.h>
+#include <dm/of_extra.h>
 #include <linux/bitops.h>
 #include <linux/delay.h>
 #include <linux/errno.h>
@@ -707,8 +708,7 @@  static int init_phy(struct tsec_private *priv)
 		tsec_configure_serdes(priv);
 
 #if defined(CONFIG_DM_ETH) && defined(CONFIG_DM_MDIO)
-	if (ofnode_valid(ofnode_find_subnode(dev_ofnode(priv->dev),
-					     "fixed-link")))
+	if (ofnode_phy_is_fixed_link(dev_ofnode(priv->dev), NULL))
 		phydev = phy_connect(NULL, 0, priv->dev, priv->interface);
 	else
 		phydev = dm_eth_phy_connect(priv->dev);

[09/20] net: tsec: Use ofnode_phy_is_fixed_link() API

Commit Message

Comments

Patch