diff mbox series

[U-Boot,v2,4/6] efi_loader: helloworld: Output ACPI configuration table

Message ID 1530094573-7814-4-git-send-email-bmeng.cn@gmail.com
State Superseded
Delegated to: Bin Meng
Headers show
Series [U-Boot,v2,1/6] x86: efi_loader: Build EFI memory map per E820 table | expand

Commit Message

Bin Meng June 27, 2018, 10:16 a.m. UTC
Output ACPI configuration table if it exists.

Signed-off-by: Bin Meng <bmeng.cn@gmail.com>

---

Changes in v2:
- new patch "output ACPI configuration table"

 lib/efi_loader/helloworld.c | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Heinrich Schuchardt June 27, 2018, 4:52 p.m. UTC | #1
On 06/27/2018 12:16 PM, Bin Meng wrote:
> Output ACPI configuration table if it exists.
> 
> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
> 
> ---
> 
> Changes in v2:
> - new patch "output ACPI configuration table"
> 
>  lib/efi_loader/helloworld.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/lib/efi_loader/helloworld.c b/lib/efi_loader/helloworld.c
> index 046b46a..df7c82b 100644
> --- a/lib/efi_loader/helloworld.c
> +++ b/lib/efi_loader/helloworld.c
> @@ -14,6 +14,7 @@
>  
>  static const efi_guid_t loaded_image_guid = LOADED_IMAGE_GUID;
>  static const efi_guid_t fdt_guid = EFI_FDT_GUID;
> +static const efi_guid_t acpi_guid = ACPI_20_TABLE_GUID;

The UEFI standard calls the constant EFI_ACPI_20_TABLE_GUID or
EFI_ACPI_TABLE_GUID. You will have to adjust this line if you adjust the
include.

>  static const efi_guid_t smbios_guid = SMBIOS_TABLE_GUID;
>  
>  static int hw_memcmp(const void *buf1, const void *buf2, size_t length)
> @@ -79,6 +80,9 @@ efi_status_t EFIAPI efi_main(efi_handle_t handle,
>  		if (!hw_memcmp(&systable->tables[i].guid, &fdt_guid,
>  			       sizeof(efi_guid_t)))
>  			con_out->output_string(con_out, L"Have device tree\n");
> +		if (!hw_memcmp(&systable->tables[i].guid, &acpi_guid,
> +			       sizeof(efi_guid_t)))
> +			con_out->output_string(con_out, L"Have ACPI table\n");

As the guid refers to ACPI 2.0 (in contrast to ACPI_TABLE_GUID) I would
prefer L"Have ACPI 2.0 table\n".

Best regards

Heinrich

>  		if (!hw_memcmp(&systable->tables[i].guid, &smbios_guid,
>  			       sizeof(efi_guid_t)))
>  			con_out->output_string(con_out, L"Have SMBIOS table\n");
>
diff mbox series

Patch

diff --git a/lib/efi_loader/helloworld.c b/lib/efi_loader/helloworld.c
index 046b46a..df7c82b 100644
--- a/lib/efi_loader/helloworld.c
+++ b/lib/efi_loader/helloworld.c
@@ -14,6 +14,7 @@ 
 
 static const efi_guid_t loaded_image_guid = LOADED_IMAGE_GUID;
 static const efi_guid_t fdt_guid = EFI_FDT_GUID;
+static const efi_guid_t acpi_guid = ACPI_20_TABLE_GUID;
 static const efi_guid_t smbios_guid = SMBIOS_TABLE_GUID;
 
 static int hw_memcmp(const void *buf1, const void *buf2, size_t length)
@@ -79,6 +80,9 @@  efi_status_t EFIAPI efi_main(efi_handle_t handle,
 		if (!hw_memcmp(&systable->tables[i].guid, &fdt_guid,
 			       sizeof(efi_guid_t)))
 			con_out->output_string(con_out, L"Have device tree\n");
+		if (!hw_memcmp(&systable->tables[i].guid, &acpi_guid,
+			       sizeof(efi_guid_t)))
+			con_out->output_string(con_out, L"Have ACPI table\n");
 		if (!hw_memcmp(&systable->tables[i].guid, &smbios_guid,
 			       sizeof(efi_guid_t)))
 			con_out->output_string(con_out, L"Have SMBIOS table\n");