| Message ID | 1530094573-7814-2-git-send-email-bmeng.cn@gmail.com |
|---|---|
| State | Superseded |
| Delegated to: | Bin Meng |
| Headers | show |
| Series | [U-Boot,v2,1/6] x86: efi_loader: Build EFI memory map per E820 table | expand |
On 06/27/2018 12:16 PM, Bin Meng wrote: > At present the number of configuration tables is set to 2. By > looking at which tables the Linux EFI stub or iPXE can process, > it looks 16 is a reasonable number. > > Signed-off-by: Bin Meng <bmeng.cn@gmail.com> > > --- > > Changes in v2: > - new patch "increase number of configuration tables to 16" > > lib/efi_loader/efi_boottime.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/efi_loader/efi_boottime.c b/lib/efi_loader/efi_boottime.c > index 50d3115..261d66d 100644 > --- a/lib/efi_loader/efi_boottime.c > +++ b/lib/efi_loader/efi_boottime.c > @@ -43,7 +43,7 @@ static bool efi_is_direct_boot = true; > * In most cases we want to pass an FDT to the payload, so reserve one slot of > * config table space for it. The pointer gets populated by do_bootefi_exec(). > */ > -static struct efi_configuration_table __efi_runtime_data efi_conf_table[2]; > +static struct efi_configuration_table __efi_runtime_data efi_conf_table[16]; Alex suggested to make this a pointer to be allocated at runtime. But this will involve further changes like updating the crc32 in the header. I prefer to change this value to 16 in this patch series to cut down the size of your patch series. Later we can provide a separate patch series that allocates the space from pool, updates crc32, and provides a test case for the table management including a test if the correct event group is being notified. Reviewed-by: Heinrich Schuchardt <xypron.glpk@gmx.de> > > #ifdef CONFIG_ARM > /* >
diff --git a/lib/efi_loader/efi_boottime.c b/lib/efi_loader/efi_boottime.c index 50d3115..261d66d 100644 --- a/lib/efi_loader/efi_boottime.c +++ b/lib/efi_loader/efi_boottime.c @@ -43,7 +43,7 @@ static bool efi_is_direct_boot = true; * In most cases we want to pass an FDT to the payload, so reserve one slot of * config table space for it. The pointer gets populated by do_bootefi_exec(). */ -static struct efi_configuration_table __efi_runtime_data efi_conf_table[2]; +static struct efi_configuration_table __efi_runtime_data efi_conf_table[16]; #ifdef CONFIG_ARM /*
At present the number of configuration tables is set to 2. By looking at which tables the Linux EFI stub or iPXE can process, it looks 16 is a reasonable number. Signed-off-by: Bin Meng <bmeng.cn@gmail.com> --- Changes in v2: - new patch "increase number of configuration tables to 16" lib/efi_loader/efi_boottime.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)