| Message ID | 20211208163255.114660-65-hare@suse.de |
|---|---|
| State | New |
| Headers | show |
| Series | libata: rework logging, take II | expand |
On 08.12.2021 19:32, Hannes Reinecke wrote: > Convert blank printk() calls to structured logging. > > Signed-off-by: Hannes Reinecke <hare@suse.de> > --- > drivers/ata/pata_sil680.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/ata/pata_sil680.c b/drivers/ata/pata_sil680.c > index 81238e097fe2..0da58ce20d82 100644 > --- a/drivers/ata/pata_sil680.c > +++ b/drivers/ata/pata_sil680.c > @@ -308,17 +308,17 @@ static u8 sil680_init_chip(struct pci_dev *pdev, int *try_mmio) > > switch (tmpbyte & 0x30) { > case 0x00: > - printk(KERN_INFO "sil680: 100MHz clock.\n"); > + dev_info(&pdev->dev, "sil680: 100MHz clock.\n"); > break; > case 0x10: > - printk(KERN_INFO "sil680: 133MHz clock.\n"); > + dev_info(&pdev->dev, "sil680: 133MHz clock.\n"); > break; > case 0x20: > - printk(KERN_INFO "sil680: Using PCI clock.\n"); > + dev_info(&pdev->dev, "sil680: Using PCI clock.\n"); > break; > /* This last case is _NOT_ ok */ > case 0x30: > - printk(KERN_ERR "sil680: Clock disabled ?\n"); > + dev_err(&pdev->dev, "sil680: Clock disabled ?\n"); Could remove a space before ?, while at it? [...] MBR, Sergey
diff --git a/drivers/ata/pata_sil680.c b/drivers/ata/pata_sil680.c index 81238e097fe2..0da58ce20d82 100644 --- a/drivers/ata/pata_sil680.c +++ b/drivers/ata/pata_sil680.c @@ -308,17 +308,17 @@ static u8 sil680_init_chip(struct pci_dev *pdev, int *try_mmio) switch (tmpbyte & 0x30) { case 0x00: - printk(KERN_INFO "sil680: 100MHz clock.\n"); + dev_info(&pdev->dev, "sil680: 100MHz clock.\n"); break; case 0x10: - printk(KERN_INFO "sil680: 133MHz clock.\n"); + dev_info(&pdev->dev, "sil680: 133MHz clock.\n"); break; case 0x20: - printk(KERN_INFO "sil680: Using PCI clock.\n"); + dev_info(&pdev->dev, "sil680: Using PCI clock.\n"); break; /* This last case is _NOT_ ok */ case 0x30: - printk(KERN_ERR "sil680: Clock disabled ?\n"); + dev_err(&pdev->dev, "sil680: Clock disabled ?\n"); } return tmpbyte & 0x30; }
Convert blank printk() calls to structured logging. Signed-off-by: Hannes Reinecke <hare@suse.de> --- drivers/ata/pata_sil680.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)