diff mbox series

[59/73] pata_cypressx: convert blank printk() calls

Message ID 20211208163255.114660-60-hare@suse.de
State New
Headers show
Series libata: rework logging, take II | expand

Commit Message

Hannes Reinecke Dec. 8, 2021, 4:32 p.m. UTC 
Convert blank printk() calls to structured logging.

Signed-off-by: Hannes Reinecke <hare@suse.de>
---
 drivers/ata/pata_cypress.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Sergey Shtylyov Dec. 9, 2021, 8:25 a.m. UTC | #1 
On 08.12.2021 19:32, Hannes Reinecke wrote:

> Convert blank printk() calls to structured logging.
> 
> Signed-off-by: Hannes Reinecke <hare@suse.de>
> ---
>   drivers/ata/pata_cypress.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/ata/pata_cypress.c b/drivers/ata/pata_cypress.c
> index 5b3a7a8ebef6..3be5d52a777b 100644
> --- a/drivers/ata/pata_cypress.c
> +++ b/drivers/ata/pata_cypress.c
> @@ -62,7 +62,7 @@ static void cy82c693_set_piomode(struct ata_port *ap, struct ata_device *adev)
>   	u32 addr;
>   
>   	if (ata_timing_compute(adev, adev->pio_mode, &t, T, 1) < 0) {
> -		printk(KERN_ERR DRV_NAME ": mome computation failed.\n");
> +		ata_dev_err(adev, DRV_NAME ": mome computation failed.\n");

    s/mome/mode/?

[...]

MBR, Sergey
diff mbox series

Patch

diff --git a/drivers/ata/pata_cypress.c b/drivers/ata/pata_cypress.c
index 5b3a7a8ebef6..3be5d52a777b 100644
--- a/drivers/ata/pata_cypress.c
+++ b/drivers/ata/pata_cypress.c
@@ -62,7 +62,7 @@  static void cy82c693_set_piomode(struct ata_port *ap, struct ata_device *adev)
 	u32 addr;
 
 	if (ata_timing_compute(adev, adev->pio_mode, &t, T, 1) < 0) {
-		printk(KERN_ERR DRV_NAME ": mome computation failed.\n");
+		ata_dev_err(adev, DRV_NAME ": mome computation failed.\n");
 		return;
 	}