| Message ID | 20211208163255.114660-33-hare@suse.de |
|---|---|
| State | New |
| Headers | show |
| Series | libata: rework logging, take II | expand |
On 2021/12/09 1:32, Hannes Reinecke wrote: > Drop pointless VPRINTK() calls for entering and existing interrupt > routines and convert the remaining calls to dev_dbg(). There are no remaining calls here :) > > Signed-off-by: Hannes Reinecke <hare@suse.de> > --- > drivers/ata/pdc_adma.c | 11 ----------- > 1 file changed, 11 deletions(-) > > diff --git a/drivers/ata/pdc_adma.c b/drivers/ata/pdc_adma.c > index 2c910c4cd4de..5d6f460b2356 100644 > --- a/drivers/ata/pdc_adma.c > +++ b/drivers/ata/pdc_adma.c > @@ -284,9 +284,6 @@ static int adma_fill_sg(struct ata_queued_cmd *qc) > *(__le32 *)(buf + i) = > (pFLAGS & pEND) ? 0 : cpu_to_le32(pp->pkt_dma + i + 4); > i += 4; > - > - VPRINTK("PRD[%u] = (0x%lX, 0x%X)\n", i/4, > - (unsigned long)addr, len); > } > > if (likely(last_buf)) > @@ -302,8 +299,6 @@ static enum ata_completion_errors adma_qc_prep(struct ata_queued_cmd *qc) > u32 pkt_dma = (u32)pp->pkt_dma; > int i = 0; > > - VPRINTK("ENTER\n"); > - > adma_enter_reg_mode(qc->ap); > if (qc->tf.protocol != ATA_PROT_DMA) > return AC_ERR_OK; > @@ -379,8 +374,6 @@ static inline void adma_packet_start(struct ata_queued_cmd *qc) > struct ata_port *ap = qc->ap; > void __iomem *chan = ADMA_PORT_REGS(ap); > > - VPRINTK("ENTER, ap %p\n", ap); > - > /* fire up the ADMA engine */ > writew(aPIOMD4 | aGO, chan + ADMA_CONTROL); > } > @@ -502,14 +495,10 @@ static irqreturn_t adma_intr(int irq, void *dev_instance) > struct ata_host *host = dev_instance; > unsigned int handled = 0; > > - VPRINTK("ENTER\n"); > - > spin_lock(&host->lock); > handled = adma_intr_pkt(host) | adma_intr_mmio(host); > spin_unlock(&host->lock); > > - VPRINTK("EXIT\n"); > - > return IRQ_RETVAL(handled); > } > >
diff --git a/drivers/ata/pdc_adma.c b/drivers/ata/pdc_adma.c index 2c910c4cd4de..5d6f460b2356 100644 --- a/drivers/ata/pdc_adma.c +++ b/drivers/ata/pdc_adma.c @@ -284,9 +284,6 @@ static int adma_fill_sg(struct ata_queued_cmd *qc) *(__le32 *)(buf + i) = (pFLAGS & pEND) ? 0 : cpu_to_le32(pp->pkt_dma + i + 4); i += 4; - - VPRINTK("PRD[%u] = (0x%lX, 0x%X)\n", i/4, - (unsigned long)addr, len); } if (likely(last_buf)) @@ -302,8 +299,6 @@ static enum ata_completion_errors adma_qc_prep(struct ata_queued_cmd *qc) u32 pkt_dma = (u32)pp->pkt_dma; int i = 0; - VPRINTK("ENTER\n"); - adma_enter_reg_mode(qc->ap); if (qc->tf.protocol != ATA_PROT_DMA) return AC_ERR_OK; @@ -379,8 +374,6 @@ static inline void adma_packet_start(struct ata_queued_cmd *qc) struct ata_port *ap = qc->ap; void __iomem *chan = ADMA_PORT_REGS(ap); - VPRINTK("ENTER, ap %p\n", ap); - /* fire up the ADMA engine */ writew(aPIOMD4 | aGO, chan + ADMA_CONTROL); } @@ -502,14 +495,10 @@ static irqreturn_t adma_intr(int irq, void *dev_instance) struct ata_host *host = dev_instance; unsigned int handled = 0; - VPRINTK("ENTER\n"); - spin_lock(&host->lock); handled = adma_intr_pkt(host) | adma_intr_mmio(host); spin_unlock(&host->lock); - VPRINTK("EXIT\n"); - return IRQ_RETVAL(handled); }
Drop pointless VPRINTK() calls for entering and existing interrupt routines and convert the remaining calls to dev_dbg(). Signed-off-by: Hannes Reinecke <hare@suse.de> --- drivers/ata/pdc_adma.c | 11 ----------- 1 file changed, 11 deletions(-)