| Message ID | 20211208163255.114660-63-hare@suse.de |
|---|---|
| State | New |
| Headers | show |
| Series | libata: rework logging, take II | expand |
On 2021/12/09 1:32, Hannes Reinecke wrote: > Convert blank printk() calls to structured logging. > > Signed-off-by: Hannes Reinecke <hare@suse.de> > --- > drivers/ata/pata_rz1000.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/ata/pata_rz1000.c b/drivers/ata/pata_rz1000.c > index 3722a67083fd..8beec884836d 100644 > --- a/drivers/ata/pata_rz1000.c > +++ b/drivers/ata/pata_rz1000.c > @@ -69,7 +69,7 @@ static int rz1000_fifo_disable(struct pci_dev *pdev) > reg &= 0xDFFF; > if (pci_write_config_word(pdev, 0x40, reg) != 0) > return -1; > - printk(KERN_INFO DRV_NAME ": disabled chipset readahead.\n"); > + dev_info(&pdev->dev, "disabled chipset readahead.\n"); > return 0; > } > > @@ -97,7 +97,7 @@ static int rz1000_init_one (struct pci_dev *pdev, const struct pci_device_id *en > if (rz1000_fifo_disable(pdev) == 0) > return ata_pci_sff_init_one(pdev, ppi, &rz1000_sht, NULL, 0); > > - printk(KERN_ERR DRV_NAME ": failed to disable read-ahead on chipset..\n"); > + dev_err(&pdev->dev, "failed to disable read-ahead on chipset..\n"); While at it, make that ".." at the end a single dot ? > /* Not safe to use so skip */ > return -ENODEV; > } >
diff --git a/drivers/ata/pata_rz1000.c b/drivers/ata/pata_rz1000.c index 3722a67083fd..8beec884836d 100644 --- a/drivers/ata/pata_rz1000.c +++ b/drivers/ata/pata_rz1000.c @@ -69,7 +69,7 @@ static int rz1000_fifo_disable(struct pci_dev *pdev) reg &= 0xDFFF; if (pci_write_config_word(pdev, 0x40, reg) != 0) return -1; - printk(KERN_INFO DRV_NAME ": disabled chipset readahead.\n"); + dev_info(&pdev->dev, "disabled chipset readahead.\n"); return 0; } @@ -97,7 +97,7 @@ static int rz1000_init_one (struct pci_dev *pdev, const struct pci_device_id *en if (rz1000_fifo_disable(pdev) == 0) return ata_pci_sff_init_one(pdev, ppi, &rz1000_sht, NULL, 0); - printk(KERN_ERR DRV_NAME ": failed to disable read-ahead on chipset..\n"); + dev_err(&pdev->dev, "failed to disable read-ahead on chipset..\n"); /* Not safe to use so skip */ return -ENODEV; }
Convert blank printk() calls to structured logging. Signed-off-by: Hannes Reinecke <hare@suse.de> --- drivers/ata/pata_rz1000.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)