diff mbox

[2/2] package/powertop: depends on c++

Message ID 1427472097-30708-2-git-send-email-bernd.kuhls@t-online.de
State Superseded
Headers show

Commit Message

Bernd Kuhls March 27, 2015, 4:01 p.m. UTC
Fixes configure error due to missing c++

checking for library containing pthread_create... no
configure: error: libpthread is required but was not found

Quote from config.log:

configure:21552: checking for library containing pthread_create
configure:21583: false -o conftest    -Os    conftest.cpp -lintl  >&5
[...]
ac_cv_env_CXX_set=set
ac_cv_env_CXX_value=false

using this defconfig

BR2_TOOLCHAIN_BUILDROOT_WCHAR=y
BR2_PACKAGE_POWERTOP=y

Please note the number of .cpp files belonging to powertop

output/build/powertop-2.7$ find -iname *.cpp | wc -l
59

Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
---
 package/powertop/Config.in |   12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

Comments

Gustavo Zacarias March 31, 2015, 11:06 p.m. UTC | #1
On 03/27/2015 01:01 PM, Bernd Kuhls wrote:

> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>

.cpp files which #include <iostream> are a pretty good indication of C++ :)

Acked-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
Thomas Petazzoni April 1, 2015, 10:07 p.m. UTC | #2
Dear Bernd Kuhls,

On Fri, 27 Mar 2015 17:01:37 +0100, Bernd Kuhls wrote:
> Fixes configure error due to missing c++
> 
> checking for library containing pthread_create... no
> configure: error: libpthread is required but was not found
> 
> Quote from config.log:
> 
> configure:21552: checking for library containing pthread_create
> configure:21583: false -o conftest    -Os    conftest.cpp -lintl  >&5
> [...]
> ac_cv_env_CXX_set=set
> ac_cv_env_CXX_value=false
> 
> using this defconfig
> 
> BR2_TOOLCHAIN_BUILDROOT_WCHAR=y
> BR2_PACKAGE_POWERTOP=y
> 
> Please note the number of .cpp files belonging to powertop
> 
> output/build/powertop-2.7$ find -iname *.cpp | wc -l
> 59
> 
> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>

Applied, thanks!

Thomas
diff mbox

Patch

diff --git a/package/powertop/Config.in b/package/powertop/Config.in
index cee78e5..398764e 100644
--- a/package/powertop/Config.in
+++ b/package/powertop/Config.in
@@ -1,9 +1,8 @@ 
 config BR2_PACKAGE_POWERTOP
 	bool "powertop"
-	# pciutils dependency
-	depends on !BR2_bfin
-	# libnl dependency
-	depends on BR2_TOOLCHAIN_HAS_THREADS
+	depends on !BR2_bfin # pciutils
+	depends on BR2_INSTALL_LIBSTDCPP
+	depends on BR2_TOOLCHAIN_HAS_THREADS # libnl
 	depends on BR2_USE_WCHAR # ncurses
 	select BR2_PACKAGE_NCURSES
 	select BR2_PACKAGE_NCURSES_WCHAR
@@ -15,6 +14,7 @@  config BR2_PACKAGE_POWERTOP
 
 	  https://01.org/powertop/
 
-comment "powertop needs a toolchain w/ threads, wchar"
+comment "powertop needs a toolchain w/ C++, threads, wchar"
 	depends on !BR2_bfin
-	depends on !BR2_TOOLCHAIN_HAS_THREADS || !BR2_USE_WCHAR
+	depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_HAS_THREADS || \
+		!BR2_USE_WCHAR