[U-Boot,6/6] x86: efi: payload: Add default TSC frequency in the device tree

Message ID 1533893978-12838-6-git-send-email-bmeng.cn@gmail.com
State Accepted
Commit 7bdf39cfafd29fc1192dd1aa997b5937f92a3c74
Delegated to: Bin Meng
Headers show
Series
  • [U-Boot,1/6] x86: coreboot: Add generic coreboot payload support
Related show

Commit Message

Bin Meng Aug. 10, 2018, 9:39 a.m.
It was observed sometimes U-Boot as the EFI payload fails to boot on
QEMU. This is because TSC calibration fails with no valid frequency.
This adds default TSC frequency in the device tree.

Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
---

 arch/x86/dts/efi-x86_payload.dts | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Simon Glass Aug. 17, 2018, 12:48 p.m. | #1
On 10 August 2018 at 03:39, Bin Meng <bmeng.cn@gmail.com> wrote:
> It was observed sometimes U-Boot as the EFI payload fails to boot on
> QEMU. This is because TSC calibration fails with no valid frequency.
> This adds default TSC frequency in the device tree.
>
> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
> ---
>
>  arch/x86/dts/efi-x86_payload.dts | 4 ++++
>  1 file changed, 4 insertions(+)

Reviewed-by: Simon Glass <sjg@chromium.org>
Bin Meng Aug. 20, 2018, 5:57 a.m. | #2
On Fri, Aug 17, 2018 at 8:48 PM, Simon Glass <sjg@chromium.org> wrote:
> On 10 August 2018 at 03:39, Bin Meng <bmeng.cn@gmail.com> wrote:
>> It was observed sometimes U-Boot as the EFI payload fails to boot on
>> QEMU. This is because TSC calibration fails with no valid frequency.
>> This adds default TSC frequency in the device tree.
>>
>> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
>> ---
>>
>>  arch/x86/dts/efi-x86_payload.dts | 4 ++++
>>  1 file changed, 4 insertions(+)
>
> Reviewed-by: Simon Glass <sjg@chromium.org>

applied to u-boot-x86, thanks!

Patch

diff --git a/arch/x86/dts/efi-x86_payload.dts b/arch/x86/dts/efi-x86_payload.dts
index 19f2530..5ccb986 100644
--- a/arch/x86/dts/efi-x86_payload.dts
+++ b/arch/x86/dts/efi-x86_payload.dts
@@ -30,6 +30,10 @@ 
 		stdout-path = "/serial";
 	};
 
+	tsc-timer {
+		clock-frequency = <1000000000>;
+	};
+
 	pci {
 		compatible = "pci-x86";
 		u-boot,dm-pre-reloc;