| Message ID | 20170730144731.8961-1-bernd.kuhls@t-online.de |
|---|---|
| State | Accepted |
| Headers | show |
Hello, On Sun, 30 Jul 2017 16:47:30 +0200, Bernd Kuhls wrote: > Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de> > --- > package/snappy/snappy.mk | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Both applied, thanks. It is worth mentioning that the pthread related tweak is probably no longer needed: both uClibc and musl now use the "single library" approach, so we no longer need to link libstdc++ explicitly with libpthread. So perhaps, we could remove this workaround? Of course, this would require verifying by checking with the problematic toolchain configurations. Best regards, Thomas
>>>>> "Bernd" == Bernd Kuhls <bernd.kuhls@t-online.de> writes: > Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de> Committed to 2017.02.x, thanks.
diff --git a/package/snappy/snappy.mk b/package/snappy/snappy.mk index 2b1da8cf5..81055594c 100644 --- a/package/snappy/snappy.mk +++ b/package/snappy/snappy.mk @@ -17,7 +17,7 @@ SNAPPY_INSTALL_STAGING = YES SNAPPY_CONF_OPTS = --disable-gtest # libsnappy links with libstdc++. Some libstdc++/arch variants use -# pthread symbols for internal locking if built with thead +# pthread symbols for internal locking if built with thread # support. libstdc++ does not have a .pc file, and its .la file does # not mention -pthread. So, static linkig to libstdc++ will fail if # -pthread is not explicity linked to. Only do that for static builds.
Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de> --- package/snappy/snappy.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)