diff mbox

[2/2] package/exiv2: fix glibc pthread detection

Message ID 20170603163012.21169-2-bernd.kuhls@t-online.de
State Changes Requested
Headers show

Commit Message

Bernd Kuhls June 3, 2017, 4:30 p.m. UTC
Patch ported from librtlsdr:
https://git.busybox.net/buildroot/commit/?id=4c6eace6f756d15ae9639a503c9245d1e7fb12a9

Fixes
http://autobuild.buildroot.net/results/6c0/6c0264bf35c4cc0c4afaf6001930fdbd6125029d/

Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
---
 package/exiv2/exiv2.mk | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

Thomas Petazzoni June 3, 2017, 5:04 p.m. UTC | #1
Hello,

On Sat,  3 Jun 2017 18:30:12 +0200, Bernd Kuhls wrote:
> Patch ported from librtlsdr:
> https://git.busybox.net/buildroot/commit/?id=4c6eace6f756d15ae9639a503c9245d1e7fb12a9

Could you explain a bit more? This commit is about fixing a static
linking issue...

> Fixes
> http://autobuild.buildroot.net/results/6c0/6c0264bf35c4cc0c4afaf6001930fdbd6125029d/

... but this configuration is not a static linking one.

> -EXIV2_CONF_OPTS += -DEXIV2_ENABLE_BUILD_SAMPLES=OFF
> +EXIV2_CONF_OPTS += \
> +	-DEXIV2_ENABLE_BUILD_SAMPLES=OFF \
> +	-DTHREADS_PTHREAD_ARG=OFF

Clearly this needs a comment in the .mk file, as one could understand
this as "let's disable thread support".

Thanks!

Thomas
diff mbox

Patch

diff --git a/package/exiv2/exiv2.mk b/package/exiv2/exiv2.mk
index f56e86122..e68abb710 100644
--- a/package/exiv2/exiv2.mk
+++ b/package/exiv2/exiv2.mk
@@ -9,7 +9,9 @@  EXIV2_SITE = http://www.exiv2.org/builds
 EXIV2_SOURCE = exiv2-$(EXIV2_VERSION)-trunk.tar.gz
 EXIV2_INSTALL_STAGING = YES
 
-EXIV2_CONF_OPTS += -DEXIV2_ENABLE_BUILD_SAMPLES=OFF
+EXIV2_CONF_OPTS += \
+	-DEXIV2_ENABLE_BUILD_SAMPLES=OFF \
+	-DTHREADS_PTHREAD_ARG=OFF
 
 ifeq ($(BR2_PACKAGE_EXIV2_LENSDATA),)
 EXIV2_CONF_OPTS += -DEXIV2_ENABLE_LENSDATA=OFF