| Message ID | 1455137950-18164-1-git-send-email-bernd.kuhls@t-online.de |
|---|---|
| State | Accepted |
| Headers | show |
On 10-02-16 21:59, Bernd Kuhls wrote: > When xz was compiled before, gdb will use it as optional dependency: > > $ output/host/usr/bin/i586-buildroot-linux-uclibc-readelf -a output/target/usr/bin/gdb | grep NEEDED > 0x00000001 (NEEDED) Shared library: [libdl.so.1] > 0x00000001 (NEEDED) Shared library: [libncurses.so.5] > 0x00000001 (NEEDED) Shared library: [libz.so.1] > 0x00000001 (NEEDED) Shared library: [libm.so.1] > 0x00000001 (NEEDED) Shared library: [liblzma.so.5] > 0x00000001 (NEEDED) Shared library: [libc.so.1] > > Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de> Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> This should probably go in to 2016.02. Regards, Arnout > --- > package/gdb/gdb.mk | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/package/gdb/gdb.mk b/package/gdb/gdb.mk > index 3b0f501..32d52eb 100644 > --- a/package/gdb/gdb.mk > +++ b/package/gdb/gdb.mk > @@ -118,6 +118,13 @@ else > GDB_CONF_OPTS += --without-expat > endif > > +ifeq ($(BR2_PACKAGE_XZ),y) > +GDB_CONF_OPTS += --with-lzma > +GDB_DEPENDENCIES += xz > +else > +GDB_CONF_OPTS += --without-lzma > +endif > + > ifeq ($(BR2_PACKAGE_ZLIB),y) > GDB_CONF_OPTS += --with-zlib > GDB_DEPENDENCIES += zlib >
On 10-02-16 21:59, Bernd Kuhls wrote: > When xz was compiled before, gdb will use it as optional dependency: > > $ output/host/usr/bin/i586-buildroot-linux-uclibc-readelf -a output/target/usr/bin/gdb | grep NEEDED > 0x00000001 (NEEDED) Shared library: [libdl.so.1] > 0x00000001 (NEEDED) Shared library: [libncurses.so.5] > 0x00000001 (NEEDED) Shared library: [libz.so.1] > 0x00000001 (NEEDED) Shared library: [libm.so.1] > 0x00000001 (NEEDED) Shared library: [liblzma.so.5] > 0x00000001 (NEEDED) Shared library: [libc.so.1] > > Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de> This would obviously be needed for host-gdb as well, but that is impossible to handle without explicit host Config.in options. I really think we should go that way, there are several problems that need it. Regards, Arnout > --- > package/gdb/gdb.mk | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/package/gdb/gdb.mk b/package/gdb/gdb.mk > index 3b0f501..32d52eb 100644 > --- a/package/gdb/gdb.mk > +++ b/package/gdb/gdb.mk > @@ -118,6 +118,13 @@ else > GDB_CONF_OPTS += --without-expat > endif > > +ifeq ($(BR2_PACKAGE_XZ),y) > +GDB_CONF_OPTS += --with-lzma > +GDB_DEPENDENCIES += xz > +else > +GDB_CONF_OPTS += --without-lzma > +endif > + > ifeq ($(BR2_PACKAGE_ZLIB),y) > GDB_CONF_OPTS += --with-zlib > GDB_DEPENDENCIES += zlib >
Am Wed, 10 Feb 2016 22:14:42 +0100 schrieb Arnout Vandecappelle:
> This should probably go in to 2016.02.
Hi @all,
in the coming days I will post 60-80 patches like this one for a variety
of packages. Currently I only have a list of packages with missing
dependencies, I have yet to prepare the patches for them. Because I
consider them as bugfixes I sent the first patches based on git HEAD,
shall I continue to do so?
Regards, Bernd
Dear Arnout Vandecappelle, On Wed, 10 Feb 2016 22:23:14 +0100, Arnout Vandecappelle wrote: > This would obviously be needed for host-gdb as well, but that is impossible to > handle without explicit host Config.in options. > > I really think we should go that way, there are several problems that need it. Or explicitly disable such features in host-gdb ? Thomas
Dear Bernd Kuhls, On Wed, 10 Feb 2016 21:59:08 +0100, Bernd Kuhls wrote: > When xz was compiled before, gdb will use it as optional dependency: > > $ output/host/usr/bin/i586-buildroot-linux-uclibc-readelf -a output/target/usr/bin/gdb | grep NEEDED > 0x00000001 (NEEDED) Shared library: [libdl.so.1] > 0x00000001 (NEEDED) Shared library: [libncurses.so.5] > 0x00000001 (NEEDED) Shared library: [libz.so.1] > 0x00000001 (NEEDED) Shared library: [libm.so.1] > 0x00000001 (NEEDED) Shared library: [liblzma.so.5] > 0x00000001 (NEEDED) Shared library: [libc.so.1] > > Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de> > --- > package/gdb/gdb.mk | 7 +++++++ > 1 file changed, 7 insertions(+) Applied to master, thanks. Thomas
>>>>> "Bernd" == Bernd Kuhls <bernd.kuhls@t-online.de> writes: > Am Wed, 10 Feb 2016 22:14:42 +0100 schrieb Arnout Vandecappelle: >> This should probably go in to 2016.02. > Hi @all, > in the coming days I will post 60-80 patches like this one for a variety > of packages. Currently I only have a list of packages with missing > dependencies, I have yet to prepare the patches for them. Because I > consider them as bugfixes I sent the first patches based on git HEAD, > shall I continue to do so? Yes, please.
diff --git a/package/gdb/gdb.mk b/package/gdb/gdb.mk index 3b0f501..32d52eb 100644 --- a/package/gdb/gdb.mk +++ b/package/gdb/gdb.mk @@ -118,6 +118,13 @@ else GDB_CONF_OPTS += --without-expat endif +ifeq ($(BR2_PACKAGE_XZ),y) +GDB_CONF_OPTS += --with-lzma +GDB_DEPENDENCIES += xz +else +GDB_CONF_OPTS += --without-lzma +endif + ifeq ($(BR2_PACKAGE_ZLIB),y) GDB_CONF_OPTS += --with-zlib GDB_DEPENDENCIES += zlib
When xz was compiled before, gdb will use it as optional dependency: $ output/host/usr/bin/i586-buildroot-linux-uclibc-readelf -a output/target/usr/bin/gdb | grep NEEDED 0x00000001 (NEEDED) Shared library: [libdl.so.1] 0x00000001 (NEEDED) Shared library: [libncurses.so.5] 0x00000001 (NEEDED) Shared library: [libz.so.1] 0x00000001 (NEEDED) Shared library: [libm.so.1] 0x00000001 (NEEDED) Shared library: [liblzma.so.5] 0x00000001 (NEEDED) Shared library: [libc.so.1] Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de> --- package/gdb/gdb.mk | 7 +++++++ 1 file changed, 7 insertions(+)