diff mbox

[13/47] package/kodi-platform: new package

Message ID 1437597069-6448-14-git-send-email-bernd.kuhls@t-online.de
State Accepted
Headers show

Commit Message

Bernd Kuhls July 22, 2015, 8:30 p.m. UTC
This package is used by the PVR addon packages and has no use by itself,
therefore is does not show up in menuconfig.

Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
---
 package/kodi-platform/Config.in        |    7 +++++++
 package/kodi-platform/kodi-platform.mk |   17 +++++++++++++++++
 package/kodi/Config.in                 |    2 ++
 3 files changed, 26 insertions(+)
 create mode 100644 package/kodi-platform/Config.in
 create mode 100644 package/kodi-platform/kodi-platform.mk

Comments

Yann E. MORIN July 25, 2015, 5:13 p.m. UTC | #1
Brnd, All,

On 2015-07-22 22:30 +0200, Bernd Kuhls spake thusly:
> This package is used by the PVR addon packages and has no use by itself,
> therefore is does not show up in menuconfig.
> 
> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
[--SNIP--]
> diff --git a/package/kodi-platform/kodi-platform.mk b/package/kodi-platform/kodi-platform.mk
> new file mode 100644
> index 0000000..22d7752
> --- /dev/null
> +++ b/package/kodi-platform/kodi-platform.mk
> @@ -0,0 +1,17 @@
> +################################################################################
> +#
> +# kodi-platform
> +#
> +################################################################################
> +
> +KODI_PLATFORM_VERSION = 33b6390b5d2abe5b674f9eb04bdee19228543054
> +KODI_PLATFORM_SITE = $(call github,xbmc,kodi-platform,$(KODI_PLATFORM_VERSION))
> +KODI_PLATFORM_LICENSE = GPLv3+
> +KODI_PLATFORM_LICENSE_FILES = COPYING

First, the only two source files in there are GPLv2+, not v3+.

Second, there's no COPYING file; there's even no licensing file at all.

Regards,
Yann E. MORIN.

> +KODI_PLATFORM_INSTALL_STAGING = YES
> +KODI_PLATFORM_DEPENDENCIES = libplatform kodi
> +
> +KODI_PLATFORM_CONF_OPTS += \
> +	-DCMAKE_MODULE_PATH=$(STAGING_DIR)/usr/lib/kodi
> +
> +$(eval $(cmake-package))
Thomas Petazzoni July 30, 2015, 1:27 p.m. UTC | #2
Dear Bernd Kuhls,

On Wed, 22 Jul 2015 22:30:35 +0200, Bernd Kuhls wrote:
> This package is used by the PVR addon packages and has no use by itself,
> therefore is does not show up in menuconfig.
> 
> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
> ---
>  package/kodi-platform/Config.in        |    7 +++++++
>  package/kodi-platform/kodi-platform.mk |   17 +++++++++++++++++
>  package/kodi/Config.in                 |    2 ++
>  3 files changed, 26 insertions(+)
>  create mode 100644 package/kodi-platform/Config.in
>  create mode 100644 package/kodi-platform/kodi-platform.mk

Applied with some changes:

    [Thomas:
     - fix license information, as noticed by Yann E. Morin: the license
       is GPLv2+, not GPLv3+, and there is no COPYING file, so a short
       source file with the license header was used instead.
     - remove -DCMAKE_MODULE_PATH, no longer needed now that
       kodi-config.cmake is fixed.
     - add patch to fix kodi-platform-config.cmake for cross-compilation.]

Thomas
diff mbox

Patch

diff --git a/package/kodi-platform/Config.in b/package/kodi-platform/Config.in
new file mode 100644
index 0000000..cde1925
--- /dev/null
+++ b/package/kodi-platform/Config.in
@@ -0,0 +1,7 @@ 
+config BR2_PACKAGE_KODI_PLATFORM
+	bool
+	select BR2_PACKAGE_LIBPLATFORM
+	help
+	  Kodi add-on platform support library
+
+	  https://github.com/xbmc/kodi-platform
diff --git a/package/kodi-platform/kodi-platform.mk b/package/kodi-platform/kodi-platform.mk
new file mode 100644
index 0000000..22d7752
--- /dev/null
+++ b/package/kodi-platform/kodi-platform.mk
@@ -0,0 +1,17 @@ 
+################################################################################
+#
+# kodi-platform
+#
+################################################################################
+
+KODI_PLATFORM_VERSION = 33b6390b5d2abe5b674f9eb04bdee19228543054
+KODI_PLATFORM_SITE = $(call github,xbmc,kodi-platform,$(KODI_PLATFORM_VERSION))
+KODI_PLATFORM_LICENSE = GPLv3+
+KODI_PLATFORM_LICENSE_FILES = COPYING
+KODI_PLATFORM_INSTALL_STAGING = YES
+KODI_PLATFORM_DEPENDENCIES = libplatform kodi
+
+KODI_PLATFORM_CONF_OPTS += \
+	-DCMAKE_MODULE_PATH=$(STAGING_DIR)/usr/lib/kodi
+
+$(eval $(cmake-package))
diff --git a/package/kodi/Config.in b/package/kodi/Config.in
index 13638df..454f839 100644
--- a/package/kodi/Config.in
+++ b/package/kodi/Config.in
@@ -102,6 +102,8 @@  menuconfig BR2_PACKAGE_KODI
 
 if BR2_PACKAGE_KODI
 
+source "package/kodi-platform/Config.in"
+
 config BR2_PACKAGE_KODI_ALSA_LIB
 	bool "alsa"
 	select BR2_PACKAGE_ALSA_LIB