diff mbox

[1/1] xserver_xorg-server: Change default to X.org modular server on supported platforms

Message ID 1413744694-27659-1-git-send-email-bernd.kuhls@t-online.de
State Superseded
Headers show

Commit Message

Bernd Kuhls Oct. 19, 2014, 6:51 p.m. UTC
As discussed on IRC.

Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
---
 package/x11r7/xserver_xorg-server/Config.in |    1 +
 1 file changed, 1 insertion(+)

Comments

Thomas Petazzoni Oct. 19, 2014, 8:46 p.m. UTC | #1
Dear Bernd Kuhls,

On Sun, 19 Oct 2014 20:51:34 +0200, Bernd Kuhls wrote:

>  choice
>  	prompt "X Window System server type"
> +	default BR2_PACKAGE_XSERVER_XORG_SERVER_MODULAR if (BR2_LARGEFILE && BR2_INSTALL_LIBSTDCPP)
>  	default BR2_PACKAGE_XSERVER_XORG_SERVER_KDRIVE

While I don't object to changing to the modular server by default, I
find it weird to have a default that is different depending on the
toolchain configuration.

Thomas
Bernd Kuhls Oct. 19, 2014, 8:51 p.m. UTC | #2
Thomas Petazzoni <thomas.petazzoni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8
@public.gmane.org> wrote in news:20141019224639.2a61c29a@free-electrons.com:

>> +     default BR2_PACKAGE_XSERVER_XORG_SERVER_MODULAR if (BR2_LARGEFILE && 
BR2_INSTALL_LIBSTDCPP)
>>       default BR2_PACKAGE_XSERVER_XORG_SERVER_KDRIVE
> 
> While I don't object to changing to the modular server by default, I
> find it weird to have a default that is different depending on the
> toolchain configuration.

Hi,

the modular server depends on BR2_LARGEFILE && BR2_INSTALL_LIBSTDCPP, so I 
thought changing the default should be done only on supported archs. Is there 
a different possibility supported by Kconfig?

Regards, Bernd
diff mbox

Patch

diff --git a/package/x11r7/xserver_xorg-server/Config.in b/package/x11r7/xserver_xorg-server/Config.in
index 5581240..52ced84 100644
--- a/package/x11r7/xserver_xorg-server/Config.in
+++ b/package/x11r7/xserver_xorg-server/Config.in
@@ -62,6 +62,7 @@  if BR2_PACKAGE_XSERVER_XORG_SERVER
 
 choice
 	prompt "X Window System server type"
+	default BR2_PACKAGE_XSERVER_XORG_SERVER_MODULAR if (BR2_LARGEFILE && BR2_INSTALL_LIBSTDCPP)
 	default BR2_PACKAGE_XSERVER_XORG_SERVER_KDRIVE
 	help
 	  Select the X Window System server to use