diff mbox

[v2,2/8] boot/uboot: Replace TARGET_CONFIGURE_OPTS with TARGET_MAKE_ENV

Message ID 1420897647-25001-3-git-send-email-jkrause@posteo.de
State Changes Requested
Headers show

Commit Message

Jörg Krause Jan. 10, 2015, 1:47 p.m. UTC 
Use TARGET_MAKE_ENV instead of TARGET_CONFIGURE_OPTS for building the U-Boot
target with 'make <board>_(def)config' and 'make'.

Signed-off-by: Jörg Krause <jkrause@posteo.de>
---
Changes v1 -> v2:
  - Rewrite commit log
---
 boot/uboot/uboot.mk | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

Comments

Thomas Petazzoni Jan. 10, 2015, 3:39 p.m. UTC | #1 
Dear Jörg Krause,

On Sat, 10 Jan 2015 14:47:21 +0100, Jörg Krause wrote:
> Use TARGET_MAKE_ENV instead of TARGET_CONFIGURE_OPTS for building the U-Boot
> target with 'make <board>_(def)config' and 'make'.
> 
> Signed-off-by: Jörg Krause <jkrause@posteo.de>

Why? TARGET_CONFIGURE_OPTS is clearly not  the same as TARGET_MAKE_ENV.
While I agree that TARGET_MAKE_ENV should be passed, the commit log
should contain an explanation as to why TARGET_CONFIGURE_OPTS is not
necessary.

Thanks,

Thomas
diff mbox

Patch

diff --git a/boot/uboot/uboot.mk b/boot/uboot/uboot.mk
index a9ba054..d18ad87 100644
--- a/boot/uboot/uboot.mk
+++ b/boot/uboot/uboot.mk
@@ -94,9 +94,7 @@  UBOOT_POST_PATCH_HOOKS += UBOOT_APPLY_CUSTOM_PATCHES
 endif
 
 define UBOOT_CONFIGURE_CMDS
-	$(TARGET_CONFIGURE_OPTS) 	\
-		$(MAKE) -C $(@D) $(UBOOT_MAKE_OPTS)		\
-		$(UBOOT_BOARD_NAME)_config
+	$(TARGET_MAKE_ENV) $(MAKE) -C $(@D) $(UBOOT_MAKE_OPTS) $(UBOOT_BOARD_NAME)_config
 	@echo >> $(@D)/include/config.h
 	@echo "/* Add a wrapper around the values Buildroot sets. */" >> $(@D)/include/config.h
 	@echo "#ifndef __BR2_ADDED_CONFIG_H" >> $(@D)/include/config.h
@@ -113,9 +111,7 @@  define UBOOT_CONFIGURE_CMDS
 endef
 
 define UBOOT_BUILD_CMDS
-	$(TARGET_CONFIGURE_OPTS) 	\
-		$(MAKE) -C $(@D) $(UBOOT_MAKE_OPTS) 		\
-		$(UBOOT_MAKE_TARGET)
+	$(TARGET_MAKE_ENV) $(MAKE) -C $(@D) $(UBOOT_MAKE_OPTS) $(UBOOT_MAKE_TARGET)
 endef
 
 define UBOOT_BUILD_OMAP_IFT